D22061: Add a logging category for logs warnings

2019-08-14 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:403c617eea56: Add a logging category for logs warnings 
(authored by meven).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=63729=63735

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  CMakeLists.txt
  kconfig.categories
  src/core/CMakeLists.txt
  src/core/kconfig.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp
  src/core/kconfigwatcher.cpp
  src/core/kdesktopfile.cpp

To: meven, #frameworks, apol, cgiboudeaux
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

2019-08-14 Thread Christophe Giboudeaux 
cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R237 KConfig

BRANCH
  arcpatch-D22061

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol, cgiboudeaux
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

2019-08-14 Thread Méven Car 
meven added a comment.


  In D22061#511799 , @cgiboudeaux 
wrote:
  
  > ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it 
should be fine.
  
  
  Should be good now.
  Thank you for your feedback.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

2019-08-14 Thread Méven Car 
meven updated this revision to Diff 63729.
meven added a comment.


  Renamed kconf to kconfig, KCONF to KCONFIG, re-add the mistakenly removed 
categories file

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=62903=63729

BRANCH
  arcpatch-D22061

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  CMakeLists.txt
  kconfig.categories
  src/core/CMakeLists.txt
  src/core/kconfig.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp
  src/core/kconfigwatcher.cpp
  src/core/kdesktopfile.cpp

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

2019-08-14 Thread Christophe Giboudeaux 
cgiboudeaux added a comment.


  ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should 
be fine.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

2019-08-01 Thread Méven Car 
meven marked 2 inline comments as done.
meven added a comment.


  I have opted for the file name kconfig_core_log_settings.h for the log 
settings header file.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-08-01 Thread Méven Car 
meven updated this revision to Diff 62903.
meven added a comment.


  Rename kconf_desktop_debug.h to more appropriate kconfig_core_log_settings.h, 
do not run an unnecessary install

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=61897=62903

BRANCH
  arcpatch-D22061

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/kconfig.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp
  src/core/kconfigwatcher.cpp
  src/core/kdesktopfile.cpp

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-07-30 Thread Christophe Giboudeaux 
cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:102
> +install(FILES kconf.categories  DESTINATION 
> ${KDE_INSTALL_LOGGINGCATEGORIESDIR})
> +install(FILES kconf.categories  DESTINATION ${KDE_INSTALL_CONFDIR})

This line is not useful

> CMakeLists.txt:17
> +ecm_qt_declare_logging_category(libkconfigcore_SRCS
> +HEADER kconf_desktop_debug.h
> +IDENTIFIER KCONF_CORE_LOG

the framework is called kconfig, the public headers are called kconfig*.h, 
there's no reason to truncate the framework name.

Also, why 'deskop' in the name ? this is for kconfigcore. kconfigcore_debug.h 
sounds better

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-07-30 Thread Méven Car 
meven added a reviewer: apol.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol
Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

2019-07-17 Thread Méven Car 
meven updated this revision to Diff 61897.
meven added a comment.


  Add a logging categorie, add context to logs

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=60610=61897

BRANCH
  arcpatch-D22061

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/kconfig.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp
  src/core/kconfigwatcher.cpp
  src/core/kdesktopfile.cpp

To: meven, #frameworks
Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

2019-07-17 Thread Méven Car 
meven edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-24 Thread Mike Royal 
mikeroyal added a comment.


  This would be nice to have.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-24 Thread Méven Car 
meven updated this revision to Diff 60610.
meven added a comment.


  Add logging category for all kconfig core warnings message

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=60558=60610

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kconfig.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp
  src/core/kconfigwatcher.cpp
  src/core/kdesktopfile.cpp

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-24 Thread Aleix Pol Gonzalez 
apol added a comment.


  The patch looks good to me.
  
  I see that you're just doing KDesktopFile, but there's many others available, 
can you port the rest too?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-24 Thread Méven Car 
meven marked an inline comment as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-24 Thread Méven Car 
meven edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-24 Thread Méven Car 
meven updated this revision to Diff 60558.
meven added a comment.


  Use KCONF_CORE_LOG as identifier and kf5.kconfig.core as category_name

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=60547=60558

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kdesktopfile.cpp

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-24 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:19
> +IDENTIFIER KCONF_DESKTOP_LOG
> +CATEGORY_NAME kf5.kconfig.desktop)
> +

This is for KF5ConfigCore, I'd call it kf5.kconfig.core.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-23 Thread Méven Car 
meven added a comment.


  Thank you very much again @apol for your guidance.
  
  I am not sure my naming scheme is ideal.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-23 Thread Méven Car 
meven updated this revision to Diff 60547.
meven added a comment.


  Removed blank line

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=60546=60547

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kdesktopfile.cpp

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-23 Thread Méven Car 
meven updated this revision to Diff 60546.
meven added a comment.


  Use KCONF_DESKTOP_LOG to setup logging

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=60545=60546

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kdesktopfile.cpp

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-23 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> kdesktopfile.h:27
>  
> +#include 
> +Q_DECLARE_LOGGING_CATEGORY(kconfigLoggingDesktop)

Use ecm_qt_declare_logging_category from cmake.

This should never be in header files too, or it would spill on applications 
otherwise.

See for example how it's done in this same repo on KCONF_UPDATE_LOG.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

2019-06-23 Thread Méven Car 
meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Disable logs unless the logging category kf5.kconfig.kdesktopfile is enabled

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns