D22093: Don't show progress window for jobs that don't report progress
nicolasfella abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22093 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D22093: Don't show progress window for jobs that don't report progress
ngraham added a comment. I find myself agreeing with @apol. Here's an idea: - Don't show the progress window at all for 500 milliseconds, like Plasma's Notifications. This will prevent it from unnecessarily showing up for very quick transfers when you're sending a small file via a fast internet connection, for example - After 500 ms, show a (correctly-sized and nice-looking) window with an indeterminate progress bar - Individual plugins that actually report status will instead get a regular progress bar Does that sound sane? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22093 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22093: Don't show progress window for jobs that don't report progress
apol added a comment. I think it's valuable information that the job is in progress. How about making the progress bar indeterminate? https://doc.qt.io/qt-5/qml-qtquick-controls2-progressbar.html#indeterminate-prop REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22093 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D22093: Don't show progress window for jobs that don't report progress
nicolasfella created this revision. nicolasfella added reviewers: apol, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Most plugins (all but the youtube one) don't report any progress in their jobs. This results in a window with an empty progress bar flashing for a few seconds. Let's hide the window by default and allow plugins to enable it. TEST PLAN Shared stuff via imgur/telegram. No window appears. Share stuff via KDE Connect. Window disappears after selecting a device REPOSITORY R495 Purpose Library BRANCH noprogress REVISION DETAIL https://phabricator.kde.org/D22093 AFFECTED FILES src/job.cpp src/job.h src/plugins/youtube/youtubejobcomposite.cpp src/quick/AlternativesView.qml src/quick/RunningJob.qml src/widgets/JobDialog.qml src/widgets/menu.cpp To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
