D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart
This revision was automatically updated to reflect the committed changes. Closed by commit R39:0fb0e618bb0c: Re-map default "Switch input mode" shortcut to not confict with konsolepart (authored by ngraham). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22574?vs=62091&id=62113 REVISION DETAIL https://phabricator.kde.org/D22574 AFFECTED FILES src/view/kateview.cpp To: ngraham, #kate, #ktexteditor, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Very reasonable! Thanks. REPOSITORY R39 KTextEditor BRANCH remap-change-input-mode-shortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D22574 To: ngraham, #kate, #ktexteditor, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart
ngraham edited the summary of this revision. ngraham added reviewers: Kate, KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22574 To: ngraham, #kate, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart
ngraham created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ngraham requested review of this revision. REVISION SUMMARY kateview's "Switch input mode" feature is currently bound to [Ctrl] + [⇧] + [V] This causes two problems: 1. When the embedded konsolepart is visible, both it and Kate claim the same shortcu so neither works 2. At other times, it's easily possible to accidentally enter vi mode when you mean to paste due to residual muscle memory from having pasted test in Konsole recently For these reasons, this patch changes the default shortcut to [Ctrl] + [Alt] + [V], which is also kind of more elegant anyway since it now uses the [Alt] key and triggers alternate input modes. BUG: 409978 FIXED-INL 5.61 TEST PLAN 1. Compile 2. Open Kate 3. Hit [Ctrl] + [⇧] + [V] and see that nothing happens 4. Copy some text 5. Open embedded Konsole and paste text with [Ctrl] + [⇧] + [V] and see that it works 6. Hit [Ctrl] + [Alt] + [V] and see that it enters vi mode REPOSITORY R39 KTextEditor BRANCH remap-change-input-mode-shortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D22574 AFFECTED FILES src/view/kateview.cpp To: ngraham Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
