D22705: Deprecate KRun::runService

2020-04-14 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Should now point to ApplicationLauncherJob.
  
  And please consider porting the users, not just deprecating and letting 
others do the porting.
  
  I'm taking care of run() and runCommand() at the moment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22705

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22705: Deprecate KRun::runService

2019-07-24 Thread David Faure 
dfaure added a comment.


  Wait I'm having second thoughts about that comment :-)
  
  Let's discuss this a bit later.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22705

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22705: Deprecate KRun::runService

2019-07-24 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 62465.
nicolasfella added a comment.


  - Add @deprecated since

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22705?vs=62446=62465

BRANCH
  depre2

REVISION DETAIL
  https://phabricator.kde.org/D22705

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22705: Deprecate KRun::runService

2019-07-24 Thread Nicolas Fella 
nicolasfella marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22705

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22705: Deprecate KRun::runService

2019-07-24 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> krun.h:238
>   * @since 5.6
>   */
> +#ifndef KIOWIDGETS_NO_DEPRECATED

Add `@deprecated since` and what should be used instead

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22705

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22705: Deprecate KRun::runService

2019-07-23 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  A comment suggests to deprecate/remove it for KF6, but there's no reason we 
cannot deprecate it now

REPOSITORY
  R241 KIO

BRANCH
  depre2

REVISION DETAIL
  https://phabricator.kde.org/D22705

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns