D23224: Fix capitalization of Nextcloud

2019-08-19 Thread Albert Astals Cid
aacid closed this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu, nicolasfella, apol
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-18 Thread Luca Weiss
z3ntu added a comment.


  No, I don't have any rights here.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu, nicolasfella, apol
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Aleix Pol Gonzalez
apol added a comment.


  Do you have commit rights or you need us to land it for you?

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu, nicolasfella, apol
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Aleix Pol Gonzalez
apol accepted this revision.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu, nicolasfella, apol
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Nicolas Fella
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu, nicolasfella
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Pino Toscano
pino added a comment.


  In D23224#513556 , @z3ntu wrote:
  
  > I'm guessing the changed English strings will trigger a "untranslated 
string" warning in the translation software, so the translators should notice 
it, right?
  
  
  Yes.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Luca Weiss
z3ntu added a comment.


  I'm guessing the changed English strings will trigger a "untranslated string" 
warning in the translation software, so the translators should notice it, right?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Luca Weiss
z3ntu updated this revision to Diff 63935.
z3ntu added a comment.


  Don't change the translated strings

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23224?vs=63934=63935

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

AFFECTED FILES
  src/plugins/nextcloud/nextcloud-upload.service.in
  src/plugins/nextcloud/nextcloudplugin.json

To: z3ntu
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Roman Gilg
romangg added a comment.


  This means only change it in lines without `[..]`.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Pino Toscano
pino added a comment.


  Please do **not** change the translations manually -- there is an automatic 
system that takes care of extracting the English strings, and merging back the 
translators for desktop/json/xml/alike files.
  
  If the English text is correct but a translation is not: please notify the 
translators using the global coordination mailing list: 
https://mail.kde.org/mailman/listinfo/kde-i18n-doc

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Luca Weiss
z3ntu created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
z3ntu requested review of this revision.

REVISION SUMMARY
  Nextcloud is not written like NextCloud

TEST PLAN
  There is no more instance of 'NextCloud' in the codebase.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

AFFECTED FILES
  src/plugins/nextcloud/nextcloud-upload.service.in
  src/plugins/nextcloud/nextcloudplugin.json

To: z3ntu
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns