D23699: mode: Port away from foreach loops over members without calls to owner

2019-09-07 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2d582d7f8d46: mode: Port away from foreach loops over 
members without calls to owner (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23699?vs=65316=65617

REVISION DETAIL
  https://phabricator.kde.org/D23699

AFFECTED FILES
  src/mode/katemodeconfigpage.cpp
  src/mode/katemodemanager.cpp

To: kossebau, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D23699: mode: Port away from foreach loops over members without calls to owner

2019-09-03 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  That looks sane for me.
  If there are threads this will all break into parts, there is no need to care 
for that (the shared containers are then not the real issue).

REPOSITORY
  R39 KTextEditor

BRANCH
  portawayfromforeachforitemconstructionestimation_mode

REVISION DETAIL
  https://phabricator.kde.org/D23699

To: kossebau, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D23699: mode: Port away from foreach loops over members without calls to owner

2019-09-03 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  There is some small risk here:
  
  - overseen call chains which still call the owner and modify the container
  - other threads might access the same containers, even if class is not 
designed to be thread-safe, but wrong usages are currently caught mostly by the 
container copy
  
  GIT_SILENT

REPOSITORY
  R39 KTextEditor

BRANCH
  portawayfromforeachforitemconstructionestimation_mode

REVISION DETAIL
  https://phabricator.kde.org/D23699

AFFECTED FILES
  src/mode/katemodeconfigpage.cpp
  src/mode/katemodemanager.cpp

To: kossebau, #kate
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann