D23760: Create new "Recent folders" icon

2019-10-15 Thread Nathaniel Graham 
ngraham added a comment.


  In D23760#547560 , @meven wrote:
  
  > Any plans on updating this icon ?
  >  I think we talked about it but I can't remember the conclusion.
  >  F7600623: Screenshot_20191015_161452-2.png 

  
  
  We need to do one of the following:
  
  - create a monochrome 32px version of `folder-open-recent`
  - delete the monochrome 32px version of `document-open-recent`
  - create colorful 32px versions of both per our recent decision that >22px 
icons should all be colorful
  
  @ndavis, thoughts or preferences?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23760

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-10-15 Thread Méven Car 
meven added a comment.


  Any plans on updating this icon ?
  I think we talked about it but I can't remember the conclusion.
  F7600623: Screenshot_20191015_161452-2.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23760

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Nathaniel Graham 
ngraham added a dependent revision: D7446: [Places panel] Revamp the Recently 
Saved section.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23760

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c58bedafd926: Create new "Recent folders" icon 
(authored by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23760?vs=65526&id=65527

REVISION DETAIL
  https://phabricator.kde.org/D23760

AFFECTED FILES
  icons-dark/actions/16/folder-open-recent.svg
  icons-dark/actions/22/folder-open-recent.svg
  icons/actions/16/folder-open-recent.svg
  icons/actions/22/folder-open-recent.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Méven Car 
meven added a comment.


  In D23760#526842 , @ngraham wrote:
  
  > The document icons will also need adjustment to match this style, and also 
to correct some related visual deficiencies (e.g. the lack of a folded corner). 
We can do that next.
  
  
  Great

REPOSITORY
  R266 Breeze Icons

BRANCH
  recent-folder-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23760

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Noah Davis 
ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  recent-folder-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23760

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Nathaniel Graham 
ngraham added a comment.


  The document icons will also need adjustment to match this style, and also to 
correct some related visual deficiencies (e.g. the lack of a folded corner). We 
can do that next.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23760

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Nathaniel Graham 
ngraham updated this revision to Diff 65526.
ngraham added a comment.


  Use @ndavis' 16px version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23760?vs=65524&id=65526

BRANCH
  recent-folder-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23760

AFFECTED FILES
  icons-dark/actions/16/folder-open-recent.svg
  icons-dark/actions/22/folder-open-recent.svg
  icons/actions/16/folder-open-recent.svg
  icons/actions/22/folder-open-recent.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Noah Davis 
ndavis added a comment.


  In D23760#526835 , @meven wrote:
  
  > Also it seems to me the icon is not very similar to 
  >  F7325279: Screenshot_20190906_224006.png 

  >  The thickness of the clock pen in particular.
  >  They should be somewhat reminiscent of one another IMHO.
  
  
  That's not a 16px icon. This is more comparable: 
  `document-open-recent` 
  F7325314: Screenshot_20190906_170458.png 

  
  The size of that clock is wrong in the first place. Bottom right emblems 
should typically not be so large that they take up more than 1/4 of the whole 
icon. However, it is rather difficult to shrink that type of emblem. 
Readability is a much larger problem with the version I created. I would accept 
a version with the emblem at 7x7 px, but not the original 8x8 px size.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23760

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Méven Car 
meven added a comment.


  Also it seems to me the icon is not very similar to 
  F7325279: Screenshot_20190906_224006.png 

  The thickness of the clock pen in particular.
  They should be somewhat reminiscent of one another IMHO.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23760

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Noah Davis 
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Use this 16px icon. It's more similar to the style of the 22px icon.
  F7325261: Screenshot_20190906_163400.png 

  F7325259: folder-open-recent.svg  
  Just change `color:#232629` to `color:#eff0f1` for Breeze Dark.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23760

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23760: Create new "Recent folders" icon

2019-09-06 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Needed for D7446 .
  
  BUG: 411635
  FIXED-IN: 5.62

TEST PLAN
  F7325143: recent.png 
  F7325144: recent-dark.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  recent-folder-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23760

AFFECTED FILES
  icons-dark/actions/16/folder-open-recent.svg
  icons-dark/actions/22/folder-open-recent.svg
  icons/actions/16/folder-open-recent.svg
  icons/actions/22/folder-open-recent.svg

To: ngraham, #vdg
Cc: kde-frameworks-devel, meven, LeGast00n, GB_2, michaelh, ngraham, bruns