D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

2019-10-18 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d576ec8ae0e5: Avoid sending KDirNotify::emitFilesAdded 
when the emptytrashjob finishes (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23851?vs=68214=68215

REVISION DETAIL
  https://phabricator.kde.org/D23851

AFFECTED FILES
  src/core/emptytrashjob.cpp

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

2019-10-18 Thread Méven Car 
meven updated this revision to Diff 68214.
meven added a comment.


  Rebase on master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23851?vs=66028=68214

BRANCH
  arcpatch-D23851_1

REVISION DETAIL
  https://phabricator.kde.org/D23851

AFFECTED FILES
  src/core/emptytrashjob.cpp

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

2019-10-15 Thread Méven Car 
meven added a comment.


  If there are no objections I will merge this soonish

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23851

REVISION DETAIL
  https://phabricator.kde.org/D23851

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

2019-09-14 Thread Méven Car 
meven updated this revision to Diff 66028.
meven added a comment.


  Add a KF6 clean up todo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23851?vs=65795=66028

BRANCH
  arcpatch-D23851

REVISION DETAIL
  https://phabricator.kde.org/D23851

AFFECTED FILES
  src/core/emptytrashjob.cpp

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

2019-09-13 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah, in that case just add a `// TODO: remove this in KF6` comment.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23851

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

2019-09-13 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  +1
  
  In D23851#529463 , @ngraham wrote:
  
  > If the on;y thing that `EmptyTrashJob::slotFinished()` does now is call 
`SimpleJob::slotFinished()`, do we even still need to override the base class's 
implementation of `slotFinished()`?
  
  
  Yeah we don't, but we can't remove it because it would be a BIC.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23851

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

2019-09-11 Thread Nathaniel Graham 
ngraham added a comment.


  If the on;y thing that `EmptyTrashJob::slotFinished()` does now is call 
`SimpleJob::slotFinished()`, do we even still need to override the base class's 
implementation of `slotFinished()`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23851

To: meven, broulik, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

2019-09-10 Thread Méven Car 
meven retitled this revision from "Avoid sending KDirNotify::emitFilesAdded 
when the trash is emptied" to "Avoid sending KDirNotify::emitFilesAdded when 
the emptytrashjob finishes".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23851

To: meven, broulik, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns