D23951: Improve and clean up panel options menu entries

2019-10-21 Thread Björn Feber 
GB_2 updated this revision to Diff 68467.
GB_2 added a comment.


  Don't hide lock action here

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=8=68467

BRANCH
  arcpatch-D23951

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

2019-10-21 Thread Björn Feber 
GB_2 marked an inline comment as done.
GB_2 added a comment.


  In D23951#551472 , @mart wrote:
  
  > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in 
the UI (hide "Lock Widgets" from the UI)  i would try to go from the context 
menu plugin instead and not adding the action there by default (but still 
possible to add it)
  >  apart from that, it looks good
  
  
  Wait, doesn't that mean you won't be able to unlock it anymore?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

2019-10-21 Thread Marco Martin 
mart added a comment.


  probably some special casing for that action will still be needed in the 
panel, but should be ok

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

2019-10-21 Thread Björn Feber 
GB_2 added a comment.


  In D23951#551472 , @mart wrote:
  
  > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in 
the UI (hide "Lock Widgets" from the UI)  i would try to go from the context 
menu plugin instead and not adding the action there by default (but still 
possible to add it)
  
  
  Ok, will do that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

2019-10-21 Thread Marco Martin 
mart requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

2019-10-21 Thread Marco Martin 
mart added a comment.


  i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in the 
UI (hide "Lock Widgets" from the UI)  i would try to go from the context menu 
plugin instead and not adding the action there by default (but still possible 
to add it)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

2019-10-21 Thread David Edmundson 
davidedmundson added a comment.


  > Ping.
  
  It's already accepted by Marco isn't it?

INLINE COMMENTS

> containment.cpp:126
> +if (d->type == Types::PanelContainment || d->type == 
> Types::CustomPanelContainment) {
> +configAction->setText(i18nc("%1 is the name of the applet", 
> "Edit %1...", title()));
> +
> configAction->setIcon(QIcon::fromTheme(QStringLiteral("document-edit")));

"name of the containment" surely?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

2019-10-21 Thread Björn Feber 
GB_2 added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve and clean up panel options menu entries

2019-10-12 Thread Björn Feber 
GB_2 retitled this revision from "Improve desktop layout and panel editing UX" 
to "Improve and clean up panel options menu entries".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns