D23951: Improve desktop layout and panel editing UX

2019-09-27 Thread Nathaniel Graham 
ngraham added tasks: T11094: Improve discoverability of widget configuration, 
T10402: The Desktop Toolbox.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-26 Thread Björn Feber 
GB_2 added 1 blocking reviewer(s): Plasma.
This revision now requires review to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-26 Thread Björn Feber 
GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox 
is open.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-26 Thread Björn Feber 
GB_2 removed a dependency: D24246: Only show panel toolbox when desktop toolbox 
is open.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-26 Thread Björn Feber 
GB_2 added a dependency: D24246: Only show panel toolbox when desktop toolbox 
is open.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-25 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-24 Thread Nathaniel Graham 
ngraham added a comment.


  In D23951#537209 , @GB_2 wrote:
  
  > In D23951#537202 , @ngraham 
wrote:
  >
  > > +1 in general, but since this removes the GUI ability to enter locked 
mode, it can't land until D23952  is ready, 
which means we need to wait for a visible non-right-click method to enter Panel 
Edit Mode. Maybe for now we can put that in the Desktop Toolbox lol.
  >
  >
  > What if we don't remove the panel toolbox yet, but only show it when the 
desktop toolbox is open, similar to how widget controls used to be shown when 
you have the desktop toolbox open?
  
  
  Ooh, I like that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-24 Thread Björn Feber 
GB_2 added a comment.


  In D23951#537202 , @ngraham wrote:
  
  > we need to wait for a visible non-right-click method to enter Panel Edit 
Mode.
  
  
  I think we'll need a task for that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-24 Thread Björn Feber 
GB_2 added a comment.


  In D23951#537202 , @ngraham wrote:
  
  > +1 in general, but since this removes the GUI ability to enter locked mode, 
it can't land until D23952  is ready, which 
means we need to wait for a visible non-right-click method to enter Panel Edit 
Mode. Maybe for now we can put that in the Desktop Toolbox lol.
  
  
  What if we don't remove the panel toolbox yet, but only show it when the 
desktop toolbox is open, similar to how widget controls are shown when you have 
the desktop toolbox open.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-24 Thread Nathaniel Graham 
ngraham added a comment.


  +1 in general, but since this removes the GUI ability to enter locked mode, 
it can't land until D23952  is ready, which 
means we need to wait for a visible non-right-click method to enter Panel Edit 
Mode. Maybe for now we can put that in the Desktop Toolbox lol.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-23 Thread Björn Feber 
GB_2 added a comment.


  Changed the menu again!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-23 Thread Björn Feber 
GB_2 edited dependent revision(s), added 1: D24162: Hide "Lock Widgets" button 
from panel edit mode toolbar; removed 1: D23952: Remove panel toolbox.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-23 Thread Björn Feber 
GB_2 removed a dependency: D23950: Only show "Add Widgets..." panel context 
menu option in panel edit mode.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-23 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-23 Thread Björn Feber 
GB_2 updated this revision to Diff 8.
GB_2 added a comment.


  Fix diff

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66162&id=8

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber 
GB_2 updated this revision to Diff 66162.
GB_2 added a comment.


  Really add back "Show Alternatives..." item

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66160&id=66162

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber 
GB_2 updated this revision to Diff 66160.
GB_2 added a comment.


  Add back "Show Alternatives..." item

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66103&id=66160

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/private/applet_p.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Nathaniel Graham 
ngraham added a comment.


  OK cool, let's move the general UX discussion back into T10190 
 and use these just for implementation 
discussion.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Nathaniel Graham 
ngraham added a task: T10190: (Re)define modes when editing panels and widgets.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber 
GB_2 added a dependent revision: D23952: Remove panel toolbox clean up editing 
options.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber 
GB_2 retitled this revision from "Move "Panel Options" context menu items out 
of submenu and rename "Configure Panel..." option" to "Improve desktop layout 
and panel editing UX".
GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns