D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

2019-09-16 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D23995

To: dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

2019-09-16 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23995

To: dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

2019-09-16 Thread David Faure
dfaure created this revision.
dfaure added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  It is set by setLineEdit when the deprecated bool autoCompletion hasn't
  previously been set to false. So the commit that removed
  setAutoCompletion(false) led to an unwanted QCompleter, indirectly.

TEST PLAN
  kfind's "Look in" combobox no longer offers completion
  from the combo items (preselected, in the lineedit)

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23995

AFFECTED FILES
  src/kcombobox.cpp

To: dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns