D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

2019-10-02 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D24252

To: dfaure, cfeck, vkrause, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

2019-10-01 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  2019_09_okbutton_configurable

REVISION DETAIL
  https://phabricator.kde.org/D24252

To: dfaure, cfeck, vkrause, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

2019-09-27 Thread David Faure 
dfaure updated this revision to Diff 66975.
dfaure added a comment.


  perl -pi -e 's/buttonOK/buttonOk/g' kmessagebox.*

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24252?vs=66932&id=66975

BRANCH
  2019_09_okbutton_configurable

REVISION DETAIL
  https://phabricator.kde.org/D24252

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h
  tests/kmessageboxtest.cpp

To: dfaure, cfeck, vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

2019-09-27 Thread Nathaniel Graham 
ngraham added a comment.


  +1

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D24252

To: dfaure, cfeck, vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

2019-09-27 Thread Christoph Feck 
cfeck added a comment.


  I think it needs to be named 'buttonOk' instead of 'buttonOK'.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D24252

To: dfaure, cfeck, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

2019-09-26 Thread David Faure 
dfaure updated this revision to Diff 66932.
dfaure retitled this revision from "Make OK button configurable in 
KMessageBox::detailedSorry" to "Make OK button configurable in 
KMessageBox::sorry/detailedSorry".
dfaure added a comment.


  also add this to sorry(); fix inconsistency with Options arg, that one can 
still have a default value

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24252?vs=66930&id=66932

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24252

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h
  tests/kmessageboxtest.cpp

To: dfaure, cfeck, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns