D24467: Use ECMGenerateExportHeader to manage deprecated API better
This revision was automatically updated to reflect the committed changes. Closed by commit R306:b8bc88232471: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24467?vs=67732=67810 REVISION DETAIL https://phabricator.kde.org/D24467 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/browserextension.h src/browserrun.cpp src/browserrun.h src/readonlypart.cpp src/readonlypart.h To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24467: Use ECMGenerateExportHeader to manage deprecated API better
dfaure accepted this revision. REPOSITORY R306 KParts BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24467 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24467: Use ECMGenerateExportHeader to manage deprecated API better
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24467 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24467: Use ECMGenerateExportHeader to manage deprecated API better
kossebau updated this revision to Diff 67732. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24467?vs=67430=67732 BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24467 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/browserextension.h src/browserrun.cpp src/browserrun.h src/readonlypart.cpp src/readonlypart.h To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24467: Use ECMGenerateExportHeader to manage deprecated API better
kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D24467 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24467: Use ECMGenerateExportHeader to manage deprecated API better
kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KParts to hide deprecated API up to a given version or silence deprecation warnings after a given version, using - -DKPARTS_DISABLE_DEPRECATED_BEFORE_AND_AT - -DKPARTS_NO_DEPRECATED - -DKPARTS_DEPRECATED_WARNINGS_SINCE - -DKPARTS_NO_DEPRECATED_WARNINGS or - -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT - -DKF_NO_DEPRECATED - -DKF_DEPRECATED_WARNINGS_SINCE - -DKF_NO_DEPRECATED_WARNINGS - to build KParts optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument. TEST PLAN Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT. REPOSITORY R306 KParts BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24467 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/browserextension.h src/browserrun.cpp src/browserrun.h src/readonlypart.cpp src/readonlypart.h To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
