D24468: Use ECMGenerateExportHeader to manage deprecated API better
This revision was automatically updated to reflect the committed changes. Closed by commit R236:b935a737eda7: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24468?vs=67737=67985#toc REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24468?vs=67737=67985 REVISION DETAIL https://phabricator.kde.org/D24468 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/kactionmenu.cpp src/kactionmenu.h src/kmessagebox.h src/kmultitabbar.cpp src/kmultitabbar.h src/kratingwidget.cpp src/kratingwidget.h src/kruler.cpp src/kruler.h src/ktoolbarpopupaction.cpp src/ktoolbarpopupaction.h To: kossebau, #frameworks, cfeck, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24468: Use ECMGenerateExportHeader to manage deprecated API better
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24468 To: kossebau, #frameworks, cfeck, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24468: Use ECMGenerateExportHeader to manage deprecated API better
kossebau updated this revision to Diff 67737. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24468?vs=67431=67737 BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24468 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/kactionmenu.cpp src/kactionmenu.h src/kmessagebox.h src/kmultitabbar.cpp src/kmultitabbar.h src/kratingwidget.cpp src/kratingwidget.h src/kruler.cpp src/kruler.h src/ktoolbarpopupaction.cpp src/ktoolbarpopupaction.h To: kossebau, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24468: Use ECMGenerateExportHeader to manage deprecated API better
kossebau added a comment. If no-one objets, would be pushing on Monday evening, Oct. 14th. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D24468 To: kossebau, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24468: Use ECMGenerateExportHeader to manage deprecated API better
kossebau created this revision. kossebau added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KWidgetsAddons to hide deprecated API up to a given version or silence deprecation warnings after a given version, using - -DKWIDGETSADDONS_DISABLE_DEPRECATED_BEFORE_AND_AT - -DKWIDGETSADDONS_NO_DEPRECATED - -DKWIDGETSADDONS_DEPRECATED_WARNINGS_SINCE - -DKWIDGETSADDONS_NO_DEPRECATED_WARNINGS or - -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT - -DKF_NO_DEPRECATED - -DKF_DEPRECATED_WARNINGS_SINCE - -DKF_NO_DEPRECATED_WARNINGS - to build KWidgetsAddons optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument. TEST PLAN Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, 5.13.0, CURRENT. REPOSITORY R236 KWidgetsAddons BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24468 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/kactionmenu.cpp src/kactionmenu.h src/kmessagebox.h src/kmultitabbar.cpp src/kmultitabbar.h src/kratingwidget.cpp src/kratingwidget.h src/kruler.cpp src/kruler.h src/ktoolbarpopupaction.cpp src/ktoolbarpopupaction.h To: kossebau, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
