D24495: Use ECMGenerateExportHeader to manage deprecated API better
This revision was automatically updated to reflect the committed changes. Closed by commit R284:adb16c18d98c: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24495?vs=68093=68148 REVISION DETAIL https://phabricator.kde.org/D24495 AFFECTED FILES CMakeLists.txt autotests/klineedit_unittest.cpp src/CMakeLists.txt src/kcombobox.cpp src/kcombobox.h src/kcompletion.h src/kcompletionbase.h src/kcompletionbox.h src/klineedit.cpp src/klineedit.h src/ksortablelist.h To: kossebau, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24495: Use ECMGenerateExportHeader to manage deprecated API better
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24495 To: kossebau, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24495: Use ECMGenerateExportHeader to manage deprecated API better
kossebau updated this revision to Diff 68093. kossebau added a comment. add some missed deprecations REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24495?vs=67734=68093 BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24495 AFFECTED FILES CMakeLists.txt autotests/klineedit_unittest.cpp src/CMakeLists.txt src/kcombobox.cpp src/kcombobox.h src/kcompletion.h src/kcompletionbase.h src/kcompletionbox.h src/klineedit.cpp src/klineedit.h src/ksortablelist.h To: kossebau, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24495: Use ECMGenerateExportHeader to manage deprecated API better
kossebau updated this revision to Diff 67734. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24495?vs=67497=67734 BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24495 AFFECTED FILES CMakeLists.txt autotests/klineedit_unittest.cpp src/CMakeLists.txt src/kcombobox.cpp src/kcombobox.h src/kcompletionbase.h src/kcompletionbox.h src/klineedit.cpp src/klineedit.h src/ksortablelist.h To: kossebau, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24495: Use ECMGenerateExportHeader to manage deprecated API better
kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KCompletion to hide deprecated API up to a given version or silence deprecation warnings after a given version, using - -DKCOMPLETION_DISABLE_DEPRECATED_BEFORE_AND_AT - -DKCOMPLETION_NO_DEPRECATED - -DKCOMPLETION_DEPRECATED_WARNINGS_SINCE - -DKCOMPLETION_NO_DEPRECATED_WARNINGS or - -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT - -DKF_NO_DEPRECATED - -DKF_DEPRECATED_WARNINGS_SINCE - -DKF_NO_DEPRECATED_WARNINGS - to build KCompletion optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument. TEST PLAN Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.0.0, 4.5.0, 5.0.0, 5.46.0, CURRENT. REPOSITORY R284 KCompletion BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24495 AFFECTED FILES CMakeLists.txt autotests/klineedit_unittest.cpp src/CMakeLists.txt src/kcombobox.cpp src/kcombobox.h src/kcompletionbase.h src/kcompletionbox.h src/klineedit.cpp src/klineedit.h src/ksortablelist.h To: kossebau, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
