D24558: fix proxy setting loading
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d1a3b9d08158: fix proxy setting loading (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24558?vs=67702=67880 REVISION DETAIL https://phabricator.kde.org/D24558 AFFECTED FILES src/kcms/kio/kproxydlg.cpp To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24558: fix proxy setting loading
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Err, yeah, the call to `setPort(-1)` serves no purpose at all otherwise... REPOSITORY R241 KIO BRANCH fix-proxy-load REVISION DETAIL https://phabricator.kde.org/D24558 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24558: fix proxy setting loading
sitter added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24558 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24558: fix proxy setting loading
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY when the flag isn't set we'd set the text to urlStr, urlStr however was the original string *with* the port. since we want the port stripped we need to actually set url.url() otherwise the KCM loading its own settings would result in Proxy: [socks://localhost:1080] Port: [1080] which when written back to the file would result in broken data as we do not sanitize the proxy url text WRT port when saving TEST PLAN - set proxy - close and open kcm again - proxy values are what they were set to with no extra port duplication REPOSITORY R241 KIO BRANCH fix-proxy-load REVISION DETAIL https://phabricator.kde.org/D24558 AFFECTED FILES src/kcms/kio/kproxydlg.cpp To: sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
