D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-13 Thread Ahmad Samir 
ahmadsamir removed a task: T11577: Port Konversation away from KTcpSocket.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-13 Thread Ahmad Samir 
ahmadsamir added a comment.


  In D24588#546367 , @vkrause wrote:
  
  > In D24588#546229 , @dfaure wrote:
  >
  > > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or 
even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`.
  > >  Don't know, just wondering (not objecting). @vkrause, any opinion?
  >
  >
  > That would be my gut feeling as well, ie. have sslui depend on the abstract 
error representation, not on all possible error sources. OTOH it's not changing 
the dependency situation overall here so no strong objection to that either. In 
any case the KTcpSocket variant should be deprecated eventually.
  
  
  That makes more sense, (so I take what I said previously back... partly 
anyway; this way the implementation detail, i.e. the socket type, is hidden 
from SslUi so that it needs only a KSslErrorUiData).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-13 Thread Volker Krause 
vkrause added a comment.


  In D24588#546229 , @dfaure wrote:
  
  > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or 
even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`.
  >  Don't know, just wondering (not objecting). @vkrause, any opinion?
  
  
  That would be my gut feeling as well, ie. have sslui depend on the abstract 
error representation, not on all possible error sources. OTOH it's not changing 
the dependency situation overall here so no strong objection to that either. In 
any case the KTcpSocket variant should be deprecated eventually.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-12 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 67818.
ahmadsamir added a comment.


  @since should actually be in the future

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24588?vs=67817=67818

BRANCH
  ahmad/ktcpsocket-qsslsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24588

AFFECTED FILES
  src/widgets/sslui.cpp
  src/widgets/sslui.h

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-12 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 67817.
ahmadsamir added a comment.


  Api docs...

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24588?vs=67778=67817

BRANCH
  ahmad/ktcpsocket-qsslsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24588

AFFECTED FILES
  src/widgets/sslui.cpp
  src/widgets/sslui.h

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-12 Thread Ahmad Samir 
ahmadsamir added a comment.


  In D24588#546229 , @dfaure wrote:
  
  > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or 
even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`.
  >  Don't know, just wondering (not objecting). @vkrause, any opinion?
  
  
  My reasoning is, konversation only needs to know about 
SslUi::askIgnoreSslErrors and not  KSslErrorUiData (implementation detail in 
SslUi). It's more "streamlined" for users of askIgnoreSslErrors to pass it an 
SSL socket rather than a KSslErrorUiData object. Anyway, I don't mind either 
way.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-12 Thread David Faure 
dfaure added a comment.


  Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even 
just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`.
  Don't know, just wondering (not objecting). @vkrause, any opinion?

INLINE COMMENTS

> sslui.h:42
>  RulesStorage storedRules = RecallAndStoreRules);
> +bool KIOWIDGETS_EXPORT askIgnoreSslErrors(const QSslSocket *socket,
> +RulesStorage storedRules = RecallAndStoreRules);

Missing docu, at least @since 5.64

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-12 Thread Ahmad Samir 
ahmadsamir added a dependent revision: D24597: Port from deprecated KTcpSocket 
to QSslSocket.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-12 Thread Ahmad Samir 
ahmadsamir added a task: T11577: Port Konversation away from KTcpSocket.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

2019-10-12 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: dfaure, vkrause.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This is needed as part of porting Koversation to use QSslSocket instead
  of KTcpSocket.

TEST PLAN
  The code compiles

REPOSITORY
  R241 KIO

BRANCH
  ahmad/ktcpsocket-qsslsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24588

AFFECTED FILES
  src/widgets/sslui.cpp
  src/widgets/sslui.h

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns