D24603: Port away from deprecated KDELibs4Support

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R103:e3b8910670e3: Port away from deprecated KDELibs4Support 
(authored by ahmadsamir).

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24603?vs=67820=67831

REVISION DETAIL
  https://phabricator.kde.org/D24603

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  treeview.cpp

To: ahmadsamir, mlaurent, vkrause
Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24603: Port away from deprecated KDELibs4Support

[Volker Krause]

vkrause accepted this revision.
vkrause added a comment.


  Thanks!

REPOSITORY
  R103 KMenu Editor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24603

To: ahmadsamir, mlaurent, vkrause
Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24603: Port away from deprecated KDELibs4Support

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R103 KMenu Editor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24603

To: ahmadsamir, mlaurent
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24603: Port away from deprecated KDELibs4Support

[Ahmad Samir]

ahmadsamir added a comment.


  F7582001: kmenuedit-vs-dolphin-settings-dialog.png 

  
  Looking at kmenuedit and dolphin settings dialog, the margin and spacing look 
comparable, so those setContentMargins and setSpacing calls aren't needed any 
more.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D24603

To: ahmadsamir, mlaurent
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24603: Port away from deprecated KDELibs4Support

[Ahmad Samir]

ahmadsamir added a task: T11566: Port kmenuedit away from kdelibs4support.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D24603

To: ahmadsamir, mlaurent
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24603: Port away from deprecated KDELibs4Support

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: mlaurent.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  kmenuedit seems to work, adding new submenus and items

REPOSITORY
  R103 KMenu Editor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24603

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  treeview.cpp

To: ahmadsamir, mlaurent
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart