D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-16 Thread Ahmad Samir 
ahmadsamir abandoned this revision.

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel, mkoller
Cc: cullmann, ognarb, kde-frameworks-devel

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Christoph Cullmann 
cullmann added a comment.


  As an non-framework module, there is no need to follow the frameworks style, 
if not wanted.

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel, mkoller
Cc: cullmann, ognarb, kde-frameworks-devel

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Ahmad Samir 
ahmadsamir added a comment.


  In D24672#547744 , @mkoller wrote:
  
  > why ?
  >  I don't like lots of these changes.
  
  
  Because it doesn't follow the KDE coding style, AFAICS (and changing it to 
use that common style will make it easier for whoever is going to work on 
porting it away from kdelibs4support[1]).
  
  Anyway, if you disagree, I'll drop this review request. :)
  
  [1]https://phabricator.kde.org/T11576

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel, mkoller
Cc: ognarb, kde-frameworks-devel

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Martin Koller 
mkoller requested changes to this revision.
mkoller added a comment.
This revision now requires changes to proceed.


  why ?
  I don't like lots of these changes.

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel, mkoller
Cc: ognarb, kde-frameworks-devel

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Christoph Feck 
cfeck added a reviewer: mkoller.

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel, mkoller
Cc: ognarb, kde-frameworks-devel

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Ahmad Samir 
ahmadsamir added a comment.


  T11214  is still being discussed, and we 
can always run clang-format later on.
  
  And uncrustify-kf5 has been used before on some of the KDE repos, so it's 
sort of have been fine-tuned a bit to KDE.
  
  Anyway, I don't mind either way. :)

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel
Cc: ognarb, kde-frameworks-devel

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Carl Schwan 
ognarb added a comment.


  Instead of using uncrustify-kf5, shouldn't we use the clang-format file from 
T11214 ?

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel
Cc: ognarb, kde-frameworks-devel

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Ahmad Samir 
ahmadsamir added a task: T11576: Port kolourpaint away from kdelibs4support.

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel
Cc: kde-frameworks-devel

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Ahmad Samir 
ahmadsamir added a reviewer: kde-frameworks-devel.
ahmadsamir added a subscriber: kde-frameworks-devel.

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel
Cc: kde-frameworks-devel