D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-29 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:7ede04501eda: Grab the keyboard when KeySequenceItem is 
recording (authored by davidre).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24736?vs=68144=68960

REVISION DETAIL
  https://phabricator.kde.org/D24736

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.h

To: davidre, #frameworks, davidedmundson, apol
Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-28 Thread Aleix Pol Gonzalez 
apol accepted this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  grabkeyboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24736

To: davidre, #frameworks, davidedmundson, apol
Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-28 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 Makes sense to me.

REPOSITORY
  R296 KDeclarative

BRANCH
  grabkeyboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24736

To: davidre, #frameworks, davidedmundson
Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-28 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  grabkeyboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24736

To: davidre, #frameworks, davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-28 Thread David Redondo 
davidre added a comment.


  Ping

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24736

To: davidre, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-17 Thread David Redondo 
davidre updated this revision to Diff 68144.
davidre added a comment.


  Whitespace

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24736?vs=68143=68144

BRANCH
  grabkeyboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24736

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.h

To: davidre, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-17 Thread David Redondo 
davidre updated this revision to Diff 68143.
davidre added a comment.


  - Make helper a qquickitem instead

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24736?vs=68142=68143

BRANCH
  grabkeyboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24736

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.h

To: davidre, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-17 Thread Kai Uwe Broulik 
broulik added a comment.


  Alternatively you could make the `KeySequenceHelper` itself a `QQuickItem` so 
it gets assigned a window.

INLINE COMMENTS

> keysequencehelper.cpp:118
>  QString shortcutDisplay;
> -
> +QQuickItem* keySequenceItem;
>  //! Check the key sequence against KStandardShortcut::find()

Typically store items created by QtQuick in a `QPointer` so we can detect when 
they are garbage collected

> keysequencehelper.h:65
> +READ keySequenceItem
> +WRITE setKeySequenceItem)
>  

this needs a `NOTIFY` argument, corresponding `signal` and `emit` in the setter

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24736

To: davidre, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-17 Thread David Redondo 
davidre added a reviewer: Frameworks.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24736

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-17 Thread David Redondo 
davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Otherwise assigning a key combination which is currently bound to a global
  shortcut action will trigger the global shortcut.

TEST PLAN
  Try to assign a global shortcut to KKeySequenceItem. The global shortcut is
  not triggered - instead the steal shortcut prompt is displayed.

REPOSITORY
  R296 KDeclarative

BRANCH
  grabkeyboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24736

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.h

To: davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns