D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 added a comment.


  In D24753#550676 , @simgunz wrote:
  
  > First, thanks for the excellent work on the new icons for Okular. I really 
like them.
  >
  > I have noticed that the edit-opacity icon does not render correctly in some 
cases:
  >
  > F7636237: Screenshot_20191020_150623.png 

  >  Preview in Cuttlefish.
  >
  > F7636244: Screenshot_20191020_150857.png 

  >  Okular annotation toolbar
  
  
  Huh, I noticed that when copying the files in Dolphin, the preview also 
showed this exact distortion of the 22px icon (but not the 16px one). I'll see 
if I can make this work.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham, ndavis
Cc: simgunz, ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24753: Add edit-opacity icons

[Simone Gaiarin]

simgunz added a comment.


  First, thanks for the excellent work on the new icons for Okular. I really 
like them.
  
  I have noticed that the edit-opacity icon does not render correctly in some 
cases:
  
  F7636237: Screenshot_20191020_150623.png 

  Preview in Cuttlefish.
  
  F7636244: Screenshot_20191020_150857.png 

  Okular annotation toolbar

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham, ndavis
Cc: simgunz, ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24753: Add edit-opacity icons

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:36993fdded88: Add edit-opacity icons (authored by Rafael 
Brandmaier rafael.brandma...@kdemail.net).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24753?vs=68262=68312

REVISION DETAIL
  https://phabricator.kde.org/D24753

AFFECTED FILES
  icons-dark/actions/16/edit-opacity.svg
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/16/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24753

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a subscriber: ndavis.
ngraham added a comment.
This revision is now accepted and ready to land.


  @ndavis, you good with this?

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24753

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 68262.
trickyricky26 added a comment.


  - Remove top stripe, reduce the opacity of the remaining stripes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24753?vs=68223=68262

BRANCH
  arcpatch-D24753

REVISION DETAIL
  https://phabricator.kde.org/D24753

AFFECTED FILES
  icons-dark/actions/16/edit-opacity.svg
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/16/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

[Nathaniel Graham]

ngraham added a comment.


  Nice. I think the filled in areas might benefit from being a little bit more 
transparent to make it more obvious, particularly for the Breeze Dark version. 
Just a smidge.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REVISION SUMMARY
  This patch adds edit-opacity icons requested by Okular for D15580 
.
  
  I'm not quite sure about the naming, and even if the Qt SVG renderer can 
handle this transparency. I also considered a style with a checkerboard 
pattern, which is the symbol for transparency e.g. in GIMP, but I felt this is 
not recognizable enough to most people.
  
  I think this should be the last icon needed for 
https://bugs.kde.org/show_bug.cgi?id=408283, so I'm tagging this as closing 
that bug.
  
  BUG: 408283
  FIXED-IN: 5.64

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-opacity-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24753

AFFECTED FILES
  icons-dark/actions/16/edit-opacity.svg
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/16/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns