D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

2019-11-05 Thread Konrad Materka 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:96b7fc21f5b5: Add hideOnWindowDeactivate to 
PlasmaComponents.Dialog (authored by kmaterka).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24825?vs=68424=69323

REVISION DETAIL
  https://phabricator.kde.org/D24825

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/Dialog.qml

To: kmaterka, #plasma, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

2019-11-05 Thread David Edmundson 
davidedmundson added a comment.


  > maybe there is no point in fixing this?
  
  PlasmaComponents are dead in favour of Plasma Components 3 (which have to 
match QtQuickControls2 API)
  
  Maybe not, from what I can see the original code could use PlasmaCore.Dialog 
directly. Or the inbuilt way plasma does popups.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24825

To: kmaterka, #plasma, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

2019-11-05 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24825

To: kmaterka, #plasma, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

2019-11-05 Thread Konrad Materka 
kmaterka added a comment.


  Should I proceed? This component has serious issues anyway, maybe there is no 
point in fixing this?
  For example:
  There is Loader that load always the same QML because... "if (true || )" 
- line 241. Even if this is obsolete, cleanup would be good idea.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24825

To: kmaterka, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

2019-10-21 Thread Konrad Materka 
kmaterka added a comment.


  This is a first step to solve 401016 
:
  "Touchpad plasmoid [confirmation dialog] remains open when losing focus, I 
think that it is inconsistent since other elements of tray close themselves 
after switching away."
  
  AFAIK PlasmaComponents 2 are deprecated. Is there newer QueryDialog 
replacement?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24825

To: kmaterka, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

2019-10-21 Thread Konrad Materka 
kmaterka edited the summary of this revision.
kmaterka added reviewers: Plasma, Frameworks.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24825

To: kmaterka, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

2019-10-21 Thread Konrad Materka 
kmaterka created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  When using Dialog or QueryDialog it should be possible to set 
hideOnWindowDeactivate flag.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24825

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/Dialog.qml

To: kmaterka
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns