D25023: Make kconfig_compiler generate code with const

2019-10-29 Thread Albert Astals Cid 
aacid abandoned this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25023

To: aacid
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25023: Make kconfig_compiler generate code with const

2019-10-28 Thread Aleix Pol Gonzalez 
apol added a comment.


  I don't know if we can do that. There's been some changes we've pulled back 
assuming people could be installing + exporting classes generated from 
kconfig_compiler. :/

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25023

To: aacid
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25023: Make kconfig_compiler generate code with const

2019-10-28 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  KSharedConfig::Ptr is not very expensive to copy but const & is cheaper

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25023

AFFECTED FILES
  autotests/kconfig_compiler/test8a.cpp.ref
  autotests/kconfig_compiler/test8a.h.ref
  autotests/kconfig_compiler/test8c.cpp.ref
  autotests/kconfig_compiler/test8c.h.ref
  src/kconfig_compiler/kconfig_compiler.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns