D25041: Ensure that the changedEntries property is correctly propagated

2019-10-30 Thread Dan Leinir Turthra Jensen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:344e9b7c07ad: Ensure that the changedEntries property is 
correctly propagated (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25041?vs=68957=69030

REVISION DETAIL
  https://phabricator.kde.org/D25041

AFFECTED FILES
  src/qtquick/qml/Button.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #frameworks, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  ensure-changedentries-is-forwarded (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25041

To: leinir, #frameworks, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Nathaniel Graham 
ngraham added a dependent revision: D24942: Require and use the new 
NewStuffQuick Button component.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25041

To: leinir, #frameworks, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Dan Leinir Turthra Jensen 
leinir added reviewers: Frameworks, KNewStuff, apol, ngraham.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25041

To: leinir, #frameworks, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Dan Leinir Turthra Jensen 
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Without this change, for some reason unknown to me, the alias
  seems to fail quietly (that is, you can still read the property,
  but it does not forward the changed signal).
  
  This was discovered during the course of reviewing D24942 
.
  
  Expose the amount of changed entries
  
  Since changedEntries is only a forwarding type, and not a true list
  in the QML sense, there's no good way to get the number of entries
  (without for e.g. changing changedEntries to a model, which just
  seems like overkill)

REPOSITORY
  R304 KNewStuff

BRANCH
  ensure-changedentries-is-forwarded (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25041

AFFECTED FILES
  src/qtquick/qml/Button.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns