D25122: embedd trigrams.map into shared library

2019-11-04 Thread Christoph Cullmann 
cullmann closed this revision.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-04 Thread Christoph Cullmann 
cullmann requested review of this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, then first close this.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-04 Thread Volker Krause 
vkrause added a comment.


  In D25122#558385 , @cullmann wrote:
  
  > I re-scheduled the build, seems to work for me now.
  >
  > @vkrause : have you some solution to run the trigrams stuff for cross 
compiles, too?
  
  
  D25143  makes it generate the trigram 
file in my Android setup.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-04 Thread Christoph Cullmann 
cullmann added a comment.


  Given I did break it, sorry for the issue at all ;=)
  But still, the fix is not that nice, not trigrams there at all, like before :/

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-04 Thread Nicolas Fella 
nicolasfella added a comment.


  Thanks for the quick fix!

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann 
cullmann added a comment.


  I re-scheduled the build, seems to work for me now.
  
  @vkrause : have you some solution to run the trigrams stuff for cross 
compiles, too?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann 
cullmann added a comment.


  Fix see 
https://commits.kde.org/sonnet/be0414de6b921a1b926ea5e6c75ea3df02240379

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann 
cullmann planned changes to this revision.
cullmann added a comment.


  Ok, I see.
  For cross-compiling the trigrams were never generated...
  I don't think this is a good idea, but I can guard the resource creation with 
the same code.
  
  Volker: You are more familiar with the Android stuff, how can we fix that 
properly? Perhaps like for syntax-highlighting?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann 
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Is that because I moved the target to the other cmake file? The generation 
process should be unchanged.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Nicolas Fella 
nicolasfella added a comment.


  This seems to break several Android builds
  https://binary-factory.kde.org/view/Android/job/Koko_android/36/console

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:0c195d0ff947: embed trigrams.map into shared library 
(authored by cullmann).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25122?vs=69200=69211

REVISION DETAIL
  https://phabricator.kde.org/D25122

AFFECTED FILES
  data/CMakeLists.txt
  data/trigrams.qrc.in
  src/core/CMakeLists.txt
  src/core/guesslanguage.cpp

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25122: embedd trigrams.map into shared library

2019-11-02 Thread Christoph Cullmann 
cullmann added reviewers: dfaure, vonreth, Frameworks.
cullmann added a comment.


  Easier to deploy, we just need the shared libs and no extra data files (at 
least not for sonnet itself).

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25122

To: cullmann, dfaure, vonreth, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25122: embedd trigrams.map into shared library

2019-11-02 Thread Christoph Cullmann 
cullmann created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  Easier to deploy sonnet: just install the libraries

TEST PLAN
  make && make test

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25122

AFFECTED FILES
  data/CMakeLists.txt
  data/trigrams.qrc.in
  src/core/CMakeLists.txt
  src/core/guesslanguage.cpp

To: cullmann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns