D25123: [WIP] New yakuake logo/icon

2020-02-06 Thread Mariusz Glebocki
mglb updated this revision to Diff 75148.
mglb added a comment.


  Huh, I was waiting for @hein :) oh well, here it is - C icon with cleaned up 
source

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25123?vs=69507=75148

BRANCH
  yakuake

REVISION DETAIL
  https://phabricator.kde.org/D25123

AFFECTED FILES
  icons-dark/apps/48/yakuake.svg
  icons/apps/48/yakuake.svg

To: mglb, #vdg, #yakuake, hein
Cc: GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, numerodix, 
vmarinescu, ryanmccoskrie, LeGast00n, cblack, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2020-02-03 Thread Nathaniel Graham
ngraham added a comment.


  @mglb ping! I feel like we're really close for this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, numerodix, 
vmarinescu, ryanmccoskrie, LeGast00n, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-09 Thread Nathaniel Graham
ngraham added a comment.


  Agreed, C for me too.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, 
ryanmccoskrie, LeGast00n, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-09 Thread Björn Feber
GB_2 added a comment.


  In D25123#560491 , @ndavis wrote:
  
  > I think I prefer C the most now that I've seen it next to other icons. It 
has a similar level of detail to other Breeze icons.
  
  
  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: GB_2, ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-09 Thread Noah Davis
ndavis added a comment.


  I think I prefer C the most now that I've seen it next to other icons. It has 
a similar level of detail to other Breeze icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-09 Thread Mariusz Glebocki
mglb updated this revision to Diff 69507.
mglb added a comment.


  In D25123#558363 , @ndavis wrote:
  
  > switching to that system means we would need to change many icons.
  
  
  Let's just keep this in mind when making new icons. At least when it doesn't 
stand out too much, i.e. we shouldn't make new square icons smaller than other 
square icons just to match circles, but also don't try to fill all available 
space when there is no need to.
  
  I've aligned icons vertically. There are two new varians of "A":
  
  - A1 - Uses all available space, with larger top bar
  - A2 - Folder-icon sized, also with larger top bar. Dolphin/folder, 
system-run, and some other rectangular icons do not use full available area, 
even though they could just by scaling them up proportionally - they have 4px 
side margins and 6px up/down margins.
  
  F7750328: yakuake-icon.png 
  
  A, A1:
  F7750323: Screenshot_20191109_205001.png 
F7750324: Screenshot_20191109_205010.png 

  A2, C:
  F7750325: Screenshot_20191109_205036.png 
F7750326: Screenshot_20191109_205050.png 


REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25123?vs=69202=69507

BRANCH
  yakuake

REVISION DETAIL
  https://phabricator.kde.org/D25123

AFFECTED FILES
  icons-dark/apps/48/yakuake-a.svg
  icons-dark/apps/48/yakuake-a1.svg
  icons-dark/apps/48/yakuake-a2.svg
  icons-dark/apps/48/yakuake-b.svg
  icons-dark/apps/48/yakuake-c.svg
  icons-dark/apps/48/yakuake-d.svg
  icons-dark/apps/48/yakuake-e.svg
  icons-dark/apps/48/yakuake-f.svg
  icons-dark/apps/48/yakuake-g.svg
  icons/apps/48/yakuake-a.svg
  icons/apps/48/yakuake-a1.svg
  icons/apps/48/yakuake-a2.svg
  icons/apps/48/yakuake-b.svg
  icons/apps/48/yakuake-c.svg
  icons/apps/48/yakuake-d.svg
  icons/apps/48/yakuake-e.svg
  icons/apps/48/yakuake-f.svg
  icons/apps/48/yakuake-g.svg

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Noah Davis
ndavis added a comment.


  In D25123#558353 , @mglb wrote:
  
  > Breaking nice-looking proportions just to fill vertical space is not good 
IMO. Making the bar a bit higher might make it look more reasonably. Your 
second proposition (icon C) looks nice though.
  
  
  I agree, the modified `A` didn't turn out that well.
  
  > Note that size is perceived differently on different shapes - compare e.g. 
square and circle - with the same logical sizes, circle looks smaller (Breeze 
has this problem).
  >  The icon C is 48px wide (44px when counting only the screen), so 36px 
(38px with "handle" on the bottom) height makes its sizes visually similar to 
40x40px square icons.
  > 
  > The same applies for alignment (see e.g. plasmadiscover.svg), but that 
shouldn't be a problem here.
  
  I'm aware of that. I know Material Design uses different sizes for circles, 
squares and rectangles for that reason. Unfortunately, switching to that system 
means we would need to change many icons. I believe the reason why we use the 
system we use is because of horizontal text alignment, but I think that matters 
more for monochrome icons than color icons. On the other hand, nothing actually 
lines up with text in a way that stands out as lining up particularly well 
whether you choose 10, 11 or 12pt Noto Sans.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Mariusz Glebocki
mglb added a comment.


  In D25123#558205 , @ndavis wrote:
  
  > I tried seeing how it would look extended down to the bottom margin: 
F7728707: Screenshot_20191103_135015.png 
  
  
  Breaking nice-looking proportions just to fill vertical space is not good 
IMO. Making the bar a bit higher might make it look more reasonably. Your 
second proposition (icon C) looks nice though.
  I agree with vertical alignment - I'll fix it.
  
  In D25123#558205 , @ndavis wrote:
  
  > If not that, should we allow some icons to not reach all the way to the top 
and bottom margins? There are already some icons like that, but that doesn't 
necessarily mean we should want that.
  
  
  Note that size is perceived differently on different shapes - compare e.g. 
square and circle - with the same logical sizes, circle looks smaller (Breeze 
has this problem).
  The icon C is 48px wide (44px when counting only the screen), so 36px (38px 
with "handle" on the bottom) height makes its sizes visually similar to 40x40px 
square icons.
  
  The same applies for alignment (see e.g. plasmadiscover.svg), but that 
shouldn't be a problem here.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Nathaniel Graham
ngraham added a comment.


  In D25123#558205 , @ndavis wrote:
  
  > #vdg ,  Should we allow some types of 
icons to be vertically off center? If not that, should we allow some icons to 
not reach all the way to the top and bottom margins? There are already some 
icons like that, but that doesn't necessarily mean we should want that.
  
  
  I don't think we should allow vertically off-center icons. The only reason to 
do this is to align the baselines of all icons, but that's only useful for 
horizontal rows of icons and looks bad with vertical columns of icons or 
anytime an icon is put within a container that is centered.
  
  I recently fixed a bug report about non-centered icons that shows the 
problems arising from this: https://bugs.kde.org/show_bug.cgi?id=393550

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Noah Davis
ndavis added a comment.


  A or C for me.
  
  `A` looks more like how I imagine a "drop down terminal", but it's got a lot 
of margin below the bottom of it.
  
  I tried seeing how it would look extended down to the bottom margin: 
F7728707: Screenshot_20191103_135015.png 
  
  `C` looks more like a pull down projector screen, but that's not necessarily 
bad. It also doesn't quite reach the bottom.
  
  I tried seeing how it would look extended down to the bottom margin: 
F7728733: Screenshot_20191103_135310.png 
  
  #vdg ,  Should we allow some types of 
icons to be vertically off center? If not that, should we allow some icons to 
not reach all the way to the top and bottom margins? There are already some 
icons like that, but that doesn't necessarily mean we should want that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread KonqiDragon
KonqiDragon added a comment.


  I like A.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, 
ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Carl Schwan
ognarb added a reviewer: hein.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, 
LeGast00n, GB_2, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Nathaniel Graham
ngraham added subscribers: hein, ngraham.
ngraham added a comment.


  My vote is for A. I love it. It looks like a pull-down terminal just like the 
parent icon, re-uses the `>_` iconography common to our terminal icons, but 
adds a flair that makes the > look like a Y, conjuring up the app's name. I 
think this is fantastic.
  
  Adding @hein to the reviewers list, as he's the former maintainer.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake
Cc: ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, 
GB_2, michaelh, bruns


D25123: [WIP] New yakuake logo/icon

2019-11-02 Thread Mariusz Glebocki
mglb created this revision.
mglb added reviewers: VDG, Yakuake.
mglb added projects: Frameworks, Yakuake.
mglb requested review of this revision.

REVISION SUMMARY
  Split from: https://phabricator.kde.org/D24621
  
  This is my proposition for new yakuake logo and icon. The logo mixes a
  well known terminal symbol (`>_`) and letter "y".
  
  F7722997: yakuake-icon.png 
  
  - A..E: Main icon propositions.
- bold logo thickness (3px) is consistent with most logos around (IMO), 
including breeze adaptations of some KDE and 3rd party applications.
- thin 2px logo is consistent with original Breeze icons symbols (e.g. 
utilities-terminal, system-settings)
  - F: Alternative if people really dislike the "y_" logo.
  - G: Logo (style similar to Plasma logo AKA start-here-kde). I guess this is 
not breeze-icons material, but might be useful somewhere later (or in your 
mockups), so I'm attaching it.
  - Other combinations of background and logo are possible, especially thin 
logo on "display" background.
  
  This is how they look with some other Breeze app icons:
  F7722996: Screenshot_20191103_012256.png 

  
  Let's choose style(s) first, then we can talk about colors and common
  details present on all icons.
  My personal preference (most favored first): D, E, A, C

REPOSITORY
  R266 Breeze Icons

BRANCH
  yakuake

REVISION DETAIL
  https://phabricator.kde.org/D25123

AFFECTED FILES
  icons-dark/apps/48/yakuake-a.svg
  icons-dark/apps/48/yakuake-b.svg
  icons-dark/apps/48/yakuake-c.svg
  icons-dark/apps/48/yakuake-d.svg
  icons-dark/apps/48/yakuake-e.svg
  icons-dark/apps/48/yakuake-f.svg
  icons-dark/apps/48/yakuake-g.svg
  icons/apps/48/yakuake-a.svg
  icons/apps/48/yakuake-b.svg
  icons/apps/48/yakuake-c.svg
  icons/apps/48/yakuake-d.svg
  icons/apps/48/yakuake-e.svg
  icons/apps/48/yakuake-f.svg
  icons/apps/48/yakuake-g.svg

To: mglb, #vdg, #yakuake
Cc: kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, 
ngraham, bruns