D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:44cfa0631d25: Prepare KConfigSkeletonItem to allow 
inheriting its private class (authored by ervin).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25210?vs=69440=69673

REVISION DETAIL
  https://phabricator.kde.org/D25210

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi, vkrause
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25210

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi, vkrause
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Kevin Ottens]

ervin added a comment.


  In D25210#559977 , @vkrause wrote:
  
  > Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual 
dtor for this to actually work safely when used by a sub-class?
  
  
  You mean like not leaking memory? woops. ;-)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25210

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Kevin Ottens]

ervin updated this revision to Diff 69440.
ervin added a comment.


  Add missing virtual dtor

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25210?vs=69431=69440

REVISION DETAIL
  https://phabricator.kde.org/D25210

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Volker Krause]

vkrause added a comment.


  Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor 
for this to actually work safely when used by a sub-class?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25210

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Frameworks, dfaure, davidedmundson, bport, crossi.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25210

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns