D25340: Added background colors to active and inactive icon view

2019-12-09 Thread Noah Davis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7e52c869de2d: Added background colors to active and 
inactive icon view (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71092=71136

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-09 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D25340 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis 
ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis 
ndavis updated this revision to Diff 71092.
ndavis added a comment.


  - change minimized bg opacity to 8%

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71084=71092

BRANCH
  arcpatch-D25340 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Nathaniel Graham 
ngraham added a comment.


  This feels so close to perfection! But now it feels like the minimized bg is 
too subtle, maybe. I wonder if 0.08 opacity for minimized tasks might help. Or 
maybe I'm just torturing this poor patch to death...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis 
ndavis updated this revision to Diff 71084.
ndavis added a comment.


  - Change normal bg to 15% opacity
  - Change minimized bg to 5% opacity

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71050=71084

BRANCH
  arcpatch-D25340 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis 
ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Noah Davis 
ndavis commandeered this revision.
ndavis edited reviewers, added: niccolove; removed: ndavis.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-08 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25340#573672 , @ndavis wrote:
  
  > @niccolove Do you mind if I commandeer this? I know dealing with these 
kinds of issues can be super annoying and I'm already used to it.
  
  
  Feel free to do that :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis 
ndavis added a comment.


  @niccolove Do you mind if I commandeer this? I know dealing with these kinds 
of issues can be super annoying and I'm already used to it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis 
ndavis added a comment.


  It's still going to be a PITA with manual editing. Maybe there's a way to 
automate it with `awk`, but I don't know that tool well enough. This should at 
least make the deleting part easier: `sed --follow-symlinks -i 
's/style="opacity:0.05"//' tasks.svg`
  
  Do this too while you're at it since I noticed some useless style lines: `sed 
--follow-symlinks -i 's/style=""//' tasks.svg`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis 
ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis 
ndavis added a comment.


  Oh wait, here's the problem

INLINE COMMENTS

> tasks.svg:3206
> + transform="matrix(-1 0 0 -1 36 134)"
> + opacity=".16"
> + style="opacity:0.05">

Starts here
Conflicting opacity values. Set `opacity="0.05"` and delete the conflicting 
`style="opacity:0.05"` part.

> tasks.svg:3904
> + transform="matrix(0 1 1 0 122 89.97)"
> + opacity=".16"
> + style="opacity:0.05">

Ends here

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis 
ndavis added a comment.


  In D25340#573654 , @ngraham wrote:
  
  > Hmm, I'm not seeing any change, and the difference between open and 
maximized items is still too subtle IMO: F7804140: 
Screenshot_20191207_093912.PNG 
  >
  > If the background is a different color/opacity, I can't tell.
  
  
  When changing the SVGs for plasmashell widgets, you have to delete cache. `rm 
-r ~/.cache/plasma*`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, I'm not seeing any change, and the difference between open and maximized 
items is still too subtle IMO: F7804140: Screenshot_20191207_093912.PNG 

  
  If the background is a different color/opacity, I can't tell.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis 
ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 71050.
niccolove added a comment.


  Reset tabbar to master

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71048=71050

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25340#573594 , @ndavis wrote:
  
  > Wait, is a change to tabbar.svg supposed to be in this diff?
  
  
  Nope, I must have messed up the different arc features. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis 
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Wait, is a change to tabbar.svg supposed to be in this diff?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis 
ndavis accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 71048.
niccolove added a comment.


  Changed inactive to 5%

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=70207=71048

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-06 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I guess I should change my status to accepted given that I think this is good 
enough and already an improvement. But I think we can do even better, 
@niccolove. :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-06 Thread Filip Fila 
filipf added a comment.


  In D25340#563400 , @ndavis wrote:
  
  > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which 
isn't in git master. Do I actually need that commit for this patch to work?
  
  
  A similar issue still exists, but it does apply against master.
  
  Gave this is a quick spin and it definitely looks like an improvement.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-06 Thread Nathaniel Graham 
ngraham added a comment.


  Can we push this forward? I just triaged a bunch of bugs and found that 
https://bugs.kde.org/show_bug.cgi?id=370465 now has five duplicates. There 
seems to be quite a bit of demand for this.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-23 Thread Noah Davis 
ndavis added a comment.


  In that case, maybe 5% opacity for minimized?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-23 Thread Nathaniel Graham 
ngraham added a comment.


  I can accept this as-is, but I think I'd still prefer the background color of 
minimized apps/windows to be a bit lighter or more transparent.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-23 Thread Niccolò Venerandi 
niccolove added a comment.


  > Might be too subtle, maybe more opacity would be needed
  
  This should have a 13% vs 23% opacity, what do you think?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-23 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 70207.
niccolove added a comment.


  Changed opacity of inactive vs non-visible application background color

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69882=70207

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-19 Thread Nathaniel Graham 
ngraham added a comment.


  In D25340#563913 , @ndavis wrote:
  
  > F7769041: Screenshot_20191117_203818.png 

  >  15% Inactive BG opacity
  >  10% Minimized BG opacity
  
  
  Might be too subtle, maybe more opacity would be needed

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-19 Thread Manuel Jesús de la Fuente 
manueljlin added a comment.


  Please, consider using 3px highlight so tabs don't look like this.
  This one is from the kickoff task but it would also happen in Audio Volume.
  F7771606: IMG_20191119_151319.jpg 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Noah Davis 
ndavis added a comment.


  F7769041: Screenshot_20191117_203818.png 

  15% Inactive BG opacity
  10% Minimized BG opacity

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Noah Davis 
ndavis added a comment.


  In D25340#563908 , @ngraham wrote:
  
  > Decreasing the opacity of the icon itself? Maybe that could work.
  
  
  Not the icon, the background.
  
  > A pet peeve I have with the status quo is that minimized apps/windows have 
greater visual prominence than other ones, which seems backwards. This patch 
generally fixes that (especially for the active app/window), but now minimized 
apps/windows have a state that looks too similar to other ones. We just need to 
figure out how to make that state look de-emphasized.
  
  I agree.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Nathaniel Graham 
ngraham added a comment.


  Decreasing the opacity of the icon itself? Maybe that could work.
  
  A pet peeve I have with the status quo is that minimized apps/windows have 
greater visual prominence than other ones, which seems backwards. This patch 
generally fixes that (especially for the active app/window), but now minimized 
apps/windows have a state that looks too similar to other ones. We just need to 
figure out how to make that state look de-emphasized.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Noah Davis 
ndavis added a comment.


  In D25340#563783 , @ngraham wrote:
  
  > I don't hate the current state, let me note. It's just not what I expected, 
and I feel like I would need to get used to it rather than immediately falling 
in love with it.
  
  
  What could be done to make it better? I noticed the same feeling myself, but 
decreasing the opacity of the inactive/minimized modes felt better.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Niccolò Venerandi 
niccolove added a comment.


  Now that we got back the 3px line, I would say that it is recognizable. I 
like the idea of having the background and reinforcing the idea that 
line=visible. But it's such a minor change that I would be okay with any option 
really.
  F7768659: Screenshot_20191117_210453.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Nathaniel Graham 
ngraham added a comment.


  I don't hate the current state, let me note. It's just not what I expected, 
and I feel like I would need to get used to it rather than immediately falling 
in love with it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Nathaniel Graham 
ngraham added a comment.


  I'm not 100% sure how I feel about the change to use the same background 
color for "open" and "minimized" states and distinguish the two entirely with 
the presence or absence of a gray line. It feels very subtle, almost too much 
so. I preferred it when the open and minimized states had a more immediately 
obvious visual difference.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69882.
niccolove added a comment.


  Tweaked colors of icon view backgrounds

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69880=69882

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25340#563593 , @ndavis wrote:
  
  > Here's a cleaned up version of the file with the changes Nate and I 
requested: F7767647: tasks.svg 
  
  
  Oh sorry, I missed this. I'll use that file.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69880.
niccolove added a comment.


  Changed 2px lines to 3px

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69851=69880

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis 
ndavis added a comment.


  I wonder if the Light gray line on the inactive mode should be a little 
brighter (up to 35% opacity) or if the background for inactive and minimized 
should be a little darker (down to 15% opacity)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis 
ndavis added a comment.


  Here's a cleaned up version of the file with the changes Nate and I 
requested: F7767647: tasks.svg 
  F7767649: Screenshot_20191117_005703.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis 
ndavis added a comment.


  Unfortunately, InactiveText doesn't work and neither does DisabledText. I 
might need to change whatever library handles stylesheets for plasmashell.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Also, according to the title, the line thickness changes are unrelated, so 
they shouldn't even be included here at all. Let's make this patch only about 
adding/changing background colors, and let's discuss the line thickness in 
another patch/task.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Nathaniel Graham 
ngraham added a comment.


  I like the background changes here and I think it makes logical sense to have 
a progression of changing background colors to indicate the status. However I'm 
not a huge fan of reducing the active indicator to just 2px. It's now so small 
that it becomes kind of superfluous. I think it would look better at the 
current size, and this would be more consistent with the highlight effects that 
@ndavis is working on, IIRC.
  
  My view is that if we don't like the blue line being so visible, we should 
remove it entirely rather than making it so small that it feels like it wishes 
it didn't exist. :) Otherwise we should keep it where it is right now. I don't 
think there's anything wrong with its current size.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis 
ndavis added a comment.


  In D25340#563388 , @niccolove 
wrote:
  
  > > @ndavis said:
  > >  Here's what I think:
  > > 
  > > - The line should indicate that the app is opened, the window is not 
minimized and the window is focused (opaque blue) or inactive (opaque gray)
  > > - The background should indicate whether an app is not opened (no BG), 
minimized or inactive (semi-transparent gray), or focused (semi-transparent 
blue)
  >
  > Please note that would require change in how desktop themes are handled, 
not in the desktop theme itself, as far as I understand it. I'm afraid I don't 
have the experience to implement what you are saying; this is the best I can 
offer. Of course, if there is anybody else, it could be a good idea.
  
  
  It looks like you already did it, but the opacity levels of the inactive bars 
need to be changed. I noticed that the SVG uses black in inkscape as the base 
color for the minimized and normal (inactive) modes, but actually uses the text 
color in Plasmashell. Keep that in mind when adjusting the opacity and the 
color class should be changed to InactiveText. I haven't actually tested if 
this value works, but it should. Right now I'm playing around with your patch a 
bit.
  
  Based on my experience, this should have broken stylesheet support, but 
apparently not...
  

  


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 69851.
niccolove added a comment.


  Added background colors to active and inactive icon view

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69849=69851

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove added a comment.


  In D25340#563400 , @ndavis wrote:
  
  > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which 
isn't in git master. Do I actually need that commit for this patch to work?
  
  
  No. My bad. Let me fix.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis 
ndavis added a comment.


  This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which 
isn't in git master. Do I actually need that commit for this patch to work?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove added a subscriber: ndavis.
niccolove added a comment.


  > @ndavis said:
  >  Here's what I think:
  > 
  > - The line should indicate that the app is opened, the window is not 
minimized and the window is focused (opaque blue) or inactive (opaque gray)
  > - The background should indicate whether an app is not opened (no BG), 
minimized or inactive (semi-transparent gray), or focused (semi-transparent 
blue)
  
  Please note that would require change in how desktop themes are handled, not 
in the desktop theme itself, as far as I understand it. I'm afraid I don't have 
the experience to implement what you are saying; this is the best I can offer. 
Of course, if there is anybody else, it could be a good idea.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.
niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Added:
  
  - Light blue color for active window
  - Light gray color for inactive but not minimized window

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns