D25435: [Network Ioslave] Add Display name to network:/

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> ltoscano wrote in Messages.sh:2
> This does not work as it is, because it does not look into the 
> subdirectories. Hint for testing:
> https://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-to-create.html
> 
> I'm going to fix it (replace *.cpp with $(find . -name '*.cpp') )

Thanks I may the wrong assumption $XGETTEXT was recursive.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: ltoscano, broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> Messages.sh:2
> +#! /usr/bin/env bash
> +$XGETTEXT *.cpp -o $podir/kio5_network.pot

This does not work as it is, because it does not look into the subdirectories. 
Hint for testing:
https://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-to-create.html

I'm going to fix it (replace *.cpp with $(find . -name '*.cpp') )

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: ltoscano, broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:2f6f67aba31b: [Network Ioslave] Add Display name to 
network:/ (authored by meven).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25435?vs=70096=70107

REVISION DETAIL
  https://phabricator.kde.org/D25435

AFFECTED FILES
  network/CMakeLists.txt
  network/Messages.sh
  network/ioslave/CMakeLists.txt
  network/ioslave/networkslave.cpp

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah, perfect.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Méven Car]

meven added a comment.


  In D25435#565600 , @ngraham wrote:
  
  > Ah, I see why: because the bug report is about `remote:/`, not `network:/`. 
I guess `network needs this patch too, but it's not fully complete unless 
`remote:/` gets the same fix.
  
  
  That's why I opened D25436  to fix the 
other ioslave as well.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Nathaniel Graham]

ngraham added a comment.


  Ah, I see why: because the bug report is about `remote:/`, not `network:/`. I 
guess `network needs this patch too, but it's not fully complete unless 
`remote:/` gets the same fix.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Nathaniel Graham]

ngraham added a comment.


  Hmm, somehow this does not work for me. The "Network" place in the places 
panel still shows "." as the text.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Méven Car]

meven added a comment.


  In D25435#565544 , @broulik wrote:
  
  > I think this needs a `add_definitions(-DTRANSLATION_DOMAIN` and 
`Messages.sh` file?
  
  
  Thanks done

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Méven Car]

meven updated this revision to Diff 70096.
meven added a comment.


  Clean

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25435?vs=70095=70096

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25435

AFFECTED FILES
  network/CMakeLists.txt
  network/Messages.sh
  network/ioslave/CMakeLists.txt
  network/ioslave/networkslave.cpp

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Méven Car]

meven updated this revision to Diff 70095.
meven added a comment.


  fix

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25435?vs=70094=70095

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25435

AFFECTED FILES
  network/CMakeLists.txt
  network/Messages.sh
  network/ioslave/CMakeLists.txt
  network/ioslave/networkslave.cpp
  network/network/CMakeLists.txt

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Méven Car]

meven updated this revision to Diff 70094.
meven added a comment.


  Add translation and Messages.sh to network:/

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25435?vs=70092=70094

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25435

AFFECTED FILES
  network/Messages.sh
  network/ioslave/CMakeLists.txt
  network/ioslave/networkslave.cpp
  network/network/CMakeLists.txt

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Kai Uwe Broulik]

broulik added a comment.


  I think this needs a `add_definitions(-DTRANSLATION_DOMAIN` and `Messages.sh` 
file?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Méven Car]

meven updated this revision to Diff 70092.
meven added a comment.


  Formatting

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25435?vs=70090=70092

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25435

AFFECTED FILES
  network/ioslave/CMakeLists.txt
  network/ioslave/networkslave.cpp

To: meven, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D25435: [Network Ioslave] Add Display name to network:/

[Méven Car]

meven created this revision.
meven added reviewers: ngraham, Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  CCBUG: 414345

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25435

AFFECTED FILES
  network/ioslave/CMakeLists.txt
  network/ioslave/networkslave.cpp

To: meven, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov