D25485: Remove KIconThemes use

2019-11-23 Thread Dominik Haumann 
dhaumann added a comment.


  Makes sense, thanks.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25485

To: broulik, #frameworks, cullmann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D25485: Remove KIconThemes use

2019-11-23 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c7d64230aa34: Remove KIconThemes use (authored by broulik).
Herald added a project: Kate.
Herald added a subscriber: kwrite-devel.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25485?vs=70198&id=70199

REVISION DETAIL
  https://phabricator.kde.org/D25485

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/dialogs/katedialogs.cpp
  src/variableeditor/katehelpbutton.cpp
  src/variableeditor/katehelpbutton.h

To: broulik, #frameworks, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25485: Remove KIconThemes use

2019-11-23 Thread Christoph Cullmann 
cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D25485

To: broulik, #frameworks, cullmann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25485: Remove KIconThemes use

2019-11-23 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Frameworks, cullmann.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It was effectively unused.

TEST PLAN
  - help button on the variable editor still shows and hides as I enter and 
leave

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D25485

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/dialogs/katedialogs.cpp
  src/variableeditor/katehelpbutton.cpp
  src/variableeditor/katehelpbutton.h

To: broulik, #frameworks, cullmann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns