D25676: Add items to ColorSet and Role enums for the total number of items
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25676: Add items to ColorSet and Role enums for the total number of items
ndavis updated this revision to Diff 70717. ndavis added a comment. - Also do Effects enum REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25676?vs=70716=70717 BRANCH enum-item-counts (branched from master) REVISION DETAIL https://phabricator.kde.org/D25676 AFFECTED FILES src/kcolorscheme.cpp src/kcolorscheme.h To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25676: Add items to ColorSet and Role enums for the total number of items
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25676: Add items to ColorSet and Role enums for the total number of items
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25676: Add items to ColorSet and Role enums for the total number of items
ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25676: Add items to ColorSet and Role enums for the total number of items
ndavis added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25676: Add items to ColorSet and Role enums for the total number of items
ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY I noticed that QPalette had these, but KColorScheme didn't. Since there is no function to get the number of items in an enum for C++, it seems like it would be useful to have a built-in way to get the total number of items. I will make a follow up patch to reduce the amount of hardcoded values in KColorScheme. REPOSITORY R265 KConfigWidgets BRANCH enum-item-counts (branched from master) REVISION DETAIL https://phabricator.kde.org/D25676 AFFECTED FILES src/kcolorscheme.h To: ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
