D25770: Several enhancements to gitolite syntax definition.

2019-12-09 Thread Michael Hansen
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:44baed407ac6: Several enhancements to gitolite syntax 
definition. (authored by zrax).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25770?vs=70989=71138

REVISION DETAIL
  https://phabricator.kde.org/D25770

AFFECTED FILES
  autotests/folding/gitolite.conf.fold
  autotests/html/gitolite.conf.html
  autotests/input/gitolite.conf
  autotests/reference/gitolite.conf.ref
  data/syntax/gitolite.xml

To: zrax, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars


D25770: Several enhancements to gitolite syntax definition.

2019-12-05 Thread Michael Hansen
zrax updated this revision to Diff 70989.
zrax added a comment.


  Fix "+" in keywords to not act as a word break.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25770?vs=70974=70989

BRANCH
  gitolite-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25770

AFFECTED FILES
  autotests/folding/gitolite.conf.fold
  autotests/html/gitolite.conf.html
  autotests/input/gitolite.conf
  autotests/reference/gitolite.conf.ref
  data/syntax/gitolite.xml

To: zrax, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars


D25770: Several enhancements to gitolite syntax definition.

2019-12-05 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good. But does the highlighting work for `RW+CD`? I am wondering 
whether `+` needs to be added to the weakDeliminator list?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  gitolite-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25770

To: zrax, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars


D25770: Several enhancements to gitolite syntax definition.

2019-12-05 Thread Michael Hansen
zrax created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
zrax requested review of this revision.

REVISION SUMMARY
  - Add more keywords, including access modes
  - Highlight include directives properly
  - Fix group highlighting to not match email addresses
  - Minor default style tweaks
  - Add unit tests for gitolite syntax

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  gitolite-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25770

AFFECTED FILES
  autotests/folding/gitolite.conf.fold
  autotests/html/gitolite.conf.html
  autotests/input/gitolite.conf
  autotests/reference/gitolite.conf.ref
  data/syntax/gitolite.xml

To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann