D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

2019-12-15 Thread Christian Ehrlicher 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d80cb8c96eef: KRemoteEncoding::encoding: dont 
return temporary. Found with clazy. (authored by chehrlic).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25996?vs=71529=71572

REVISION DETAIL
  https://phabricator.kde.org/D25996

AFFECTED FILES
  src/core/kremoteencoding.cpp

To: chehrlic, thiago, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

2019-12-14 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  remoteencoding

REVISION DETAIL
  https://phabricator.kde.org/D25996

To: chehrlic, thiago, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

2019-12-14 Thread Christian Ehrlicher 
chehrlic added a comment.


  It was clazy, not me - just wanted to fix a memleak in kio :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25996

To: chehrlic, thiago, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

2019-12-14 Thread Thiago Macieira 
thiago added a comment.


  Good catch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25996

To: chehrlic, thiago, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

2019-12-14 Thread Christian Ehrlicher 
chehrlic added reviewers: thiago, dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25996

To: chehrlic, thiago, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

2019-12-14 Thread Christian Ehrlicher 
chehrlic created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chehrlic requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  remoteencoding

REVISION DETAIL
  https://phabricator.kde.org/D25996

AFFECTED FILES
  src/core/kremoteencoding.cpp

To: chehrlic
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns