D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-21 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R243:82fdd07d387d: Port to QRandomGenerator (qrand was 
deprecated in qt5.15) (authored by mlaurent).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26060?vs=71830=71928

REVISION DETAIL
  https://phabricator.kde.org/D26060

AFFECTED FILES
  autotests/kfiltertest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-20 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  port_qrandomgenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26060

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-18 Thread Laurent Montel 
mlaurent updated this revision to Diff 71830.
mlaurent added a comment.


  Move QRandomGenerator::global() outside loop

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26060?vs=71697=71830

BRANCH
  port_qrandomgenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26060

AFFECTED FILES
  autotests/kfiltertest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-18 Thread David Faure 
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfiltertest.cpp:102
>  for (int i = 0; i < 8170; ++i) {
> -data.append((char)(qrand() % 256));
>  }

Better move the QRandomGenerator::global() out of the loop, to avoid calling it 
8170 times.

> kfiltertest.cpp:117
>  
> -data.append((char)(qrand() % 256));
> +data.append((char)(QRandomGenerator::global()->bounded(256)));
>  }

(same)

REVISION DETAIL
  https://phabricator.kde.org/D26060

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-18 Thread Laurent Montel 
mlaurent added a comment.


  Ping ?:)

REVISION DETAIL
  https://phabricator.kde.org/D26060

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-16 Thread Laurent Montel 
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without qrandr

TEST PLAN
  autotest ok

REPOSITORY
  R243 KArchive

BRANCH
  port_qrandomgenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26060

AFFECTED FILES
  autotests/kfiltertest.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

2019-12-16 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.
mlaurent removed R243 KArchive as the repository for this revision.

REVISION DETAIL
  https://phabricator.kde.org/D26060

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns