D26082: Provide a method to query isImmutable attribute of a setting related to notification.

2020-01-22 Thread Cyril Rossi
crossi abandoned this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26082

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik, meven
Cc: plasma-devel, meven, bport, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26082: Provide a method to query isImmutable attribute of a setting related to notification.

2020-01-10 Thread Méven Car
meven accepted this revision.
meven added a comment.


  That seems good to me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26082

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik, meven
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26082: Provide a method to query isImmutable attribute of a setting related to notification.

2020-01-10 Thread Cyril Rossi
crossi updated this revision to Diff 73216.
crossi added a comment.


  space

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26082?vs=73215=73216

REVISION DETAIL
  https://phabricator.kde.org/D26082

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26082: Provide a method to query isImmutable attribute of a setting related to notification.

2020-01-10 Thread Cyril Rossi
crossi updated this revision to Diff 73215.
crossi added a comment.


  Add API documentation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26082?vs=71783=73215

REVISION DETAIL
  https://phabricator.kde.org/D26082

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26082: Provide a method to query isImmutable attribute of a setting related to notification.

2019-12-23 Thread Kevin Ottens
ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Looks good to me, hoping we don't have two items with the same name in 
different settings objects.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26082

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26082: Provide a method to query isImmutable attribute of a setting related to notification.

2019-12-18 Thread Cyril Rossi
crossi created this revision.
crossi added reviewers: Plasma, Frameworks, ervin, mart, davidedmundson, 
broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Allow the KCM Notifications to query the immutable status of each settings.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26082

AFFECTED FILES
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik
Cc: plasma-devel, meven, bport, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart