D26101: Port away from Qt 5.14 deprecated QList methods

[Ahmad Samir]

ahmadsamir added a comment.


  FTR, a recent discussion on #kde-devel on Freenode, which involved QSet and 
toSet(), made me understand why the original code was using toSet(), then 
fromSet(), it was to remove duplicates as QSet doesn't allow duplicates.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26101

To: ahmadsamir, #baloo, meven, bruns, astippich, dfaure
Cc: alexeymin, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26101: Port away from Qt 5.14 deprecated QList methods

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:e1ad18533db3: Port away from Qt 5.14 deprecated QList 
methods (authored by ahmadsamir).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26101?vs=71837=71885

REVISION DETAIL
  https://phabricator.kde.org/D26101

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/lib/filemonitor.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich, dfaure
Cc: alexeymin, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26101: Port away from Qt 5.14 deprecated QList methods

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  l-qt14-deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26101

To: ahmadsamir, #baloo, meven, bruns, astippich, dfaure
Cc: alexeymin, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26101: Port away from Qt 5.14 deprecated QList methods

[Alexey Min]

alexeymin added a comment.


  Partially looks similar to what I did in D26069 
 , although that's not framework

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26101

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: alexeymin, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26101: Port away from Qt 5.14 deprecated QList methods

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71837.
ahmadsamir added a task: T11553: Port KDE Frameworks away from deprecated 
methods in Qt.
ahmadsamir added a comment.


  Link to T11553 

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26101?vs=71835=71837

BRANCH
  l-qt14-deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26101

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/lib/filemonitor.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26101: Port away from Qt 5.14 deprecated QList methods

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71835.
ahmadsamir retitled this revision from "Port away from Qt 14.0 deprecated QList 
methods" to "Port away from Qt 5.14 deprecated QList methods".
ahmadsamir added a comment.


  Qt 14 hasn't been released yet (I kept thinking something looks wrong...)

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26101?vs=71834=71835

BRANCH
  l-qt14-deprecated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26101

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/lib/filemonitor.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams