D26277: KFilePlaceEditDialog: move logic into isIconEditable()
This revision was automatically updated to reflect the committed changes. Closed by commit R241:bdc2df9c1735: KFilePlaceEditDialog: move logic into isIconEditable() (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26277?vs=72341=72883 REVISION DETAIL https://phabricator.kde.org/D26277 AFFECTED FILES src/filewidgets/kfileplaceeditdialog.cpp To: elvisangelaccio, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26277: KFilePlaceEditDialog: move logic into isIconEditable()
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH isIconEditable (branched from master) REVISION DETAIL https://phabricator.kde.org/D26277 To: elvisangelaccio, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26277: KFilePlaceEditDialog: move logic into isIconEditable()
elvisangelaccio added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26277 To: elvisangelaccio, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26277: KFilePlaceEditDialog: move logic into isIconEditable()
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY Instead of relying on whether `m_iconButton` has been initialized somewhere else in the code. TEST PLAN Make sure that editing icons is still allowed only for non-Trash places. REPOSITORY R241 KIO BRANCH isIconEditable (branched from master) REVISION DETAIL https://phabricator.kde.org/D26277 AFFECTED FILES src/filewidgets/kfileplaceeditdialog.cpp To: elvisangelaccio, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
