D26420: Add a logging category to smb ioslave

2020-01-06 Thread Méven Car 
meven updated this revision to Diff 72901.
meven added a comment.


  rebase

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26420?vs=72749&id=72901

BRANCH
  arcpatch-D26420_2

REVISION DETAIL
  https://phabricator.kde.org/D26420

AFFECTED FILES
  kio-extras.categories
  smb/CMakeLists.txt
  smb/kio_smb.cpp

To: meven, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26420: Add a logging category to smb ioslave

2020-01-06 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:1360c1f0e224: Add a logging category to smb ioslave 
(authored by meven).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26420?vs=72901&id=72902

REVISION DETAIL
  https://phabricator.kde.org/D26420

AFFECTED FILES
  kio-extras.categories
  smb/CMakeLists.txt
  smb/kio_smb.cpp

To: meven, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26420: Add a logging category to smb ioslave

2020-01-04 Thread Laurent Montel 
mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D26358

REVISION DETAIL
  https://phabricator.kde.org/D26420

To: meven, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26420: Add a logging category to smb ioslave

2020-01-04 Thread Méven Car 
meven updated this revision to Diff 72749.
meven added a comment.


  indent & ""

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26420?vs=72747&id=72749

BRANCH
  arcpatch-D26358

REVISION DETAIL
  https://phabricator.kde.org/D26420

AFFECTED FILES
  kio-extras.categories
  smb/CMakeLists.txt
  smb/kio_smb.cpp

To: meven, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26420: Add a logging category to smb ioslave

2020-01-04 Thread Méven Car 
meven marked 2 inline comments as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26420

To: meven, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26420: Add a logging category to smb ioslave

2020-01-04 Thread Laurent Montel 
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:27
> +IDENTIFIER KIO_SMB_LOG
> +CATEGORY_NAME log_kio_smb)
> +

indent

> kio_smb.cpp:36
>  
> -Q_LOGGING_CATEGORY(KIO_SMB, "kio_smb")
> +#include smb-logsettings.h
>  

#include "..."

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26420

To: meven, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26420: Add a logging category to smb ioslave

2020-01-04 Thread Méven Car 
meven updated this revision to Diff 72747.
meven added a comment.


  Clean

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26420?vs=72746&id=72747

BRANCH
  arcpatch-D26358

REVISION DETAIL
  https://phabricator.kde.org/D26420

AFFECTED FILES
  kio-extras.categories
  smb/CMakeLists.txt
  smb/kio_smb.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D26420: Add a logging category to smb ioslave

2020-01-04 Thread Méven Car 
meven created this revision.
meven added a reviewer: Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D26358

REVISION DETAIL
  https://phabricator.kde.org/D26420

AFFECTED FILES
  kio-extras.categories
  smb/CMakeLists.txt
  smb/kio_smb.cpp
  smb/kio_smb.cpp.autosave

To: meven, #frameworks
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov