D26449: [PoC] Port to KRecentFileMenu

2021-04-06 Thread Nicolas Fella 
nicolasfella abandoned this revision.
nicolasfella added a comment.


  https://invent.kde.org/utilities/ark/-/merge_requests/39

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D26449

To: nicolasfella, #ark, #frameworks
Cc: meven, mlaurent, kde-utils-devel, fbampaloukas, tctara

D26449: [PoC] Port to KRecentFileMenu

2020-01-06 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> mainwindow.h:67
>  KParts::ReadWritePart *m_part;
> -KRecentFilesAction*m_recentFilesAction;
>  QAction   *m_openAction;

Rename the variable as well ?

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D26449

To: nicolasfella, #ark, #frameworks
Cc: meven, mlaurent, kde-utils-devel, fbampaloukas, tctara

D26449: [PoC] Port to KRecentFileMenu

2020-01-05 Thread Laurent Montel 
mlaurent added a comment.


  So you need to increase kf5 dependancy no ?

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D26449

To: nicolasfella, #ark, #frameworks
Cc: mlaurent, kde-utils-devel, fbampaloukas, tctara

D26449: [PoC] Port to KRecentFileMenu

2020-01-05 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added reviewers: Ark, Frameworks.
Herald added a subscriber: kde-utils-devel.
Herald added a project: Ark.
nicolasfella requested review of this revision.

REVISION SUMMARY
  PoC for using KRecentFileMenu. See D26448 

REPOSITORY
  R36 Ark

BRANCH
  refime

REVISION DETAIL
  https://phabricator.kde.org/D26449

AFFECTED FILES
  app/mainwindow.cpp
  app/mainwindow.h

To: nicolasfella, #ark, #frameworks
Cc: kde-utils-devel, fbampaloukas, tctara