D26524: configmodule: Make sure the kcm information is loaded when the qml is created
apol added a comment. hmmm. Ping @mart. :) what do you suggest we do? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26524 To: apol, #plasma, #frameworks Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D26524: configmodule: Make sure the kcm information is loaded when the qml is created
mart added a comment. that depends how heavy the load() implementation is... both ways are not optimal.. this behavior comes from KCModule, where the module nevel loads itself and a load() must be called from outside. here may be worth doing that even if it's two loads as would avoid a binding reevaluation. othe the other hand.. a config read more, hmmm REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26524 To: apol, #plasma, #frameworks Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26524: configmodule: Make sure the kcm information is loaded when the qml is created
davidedmundson added a comment. I kinda see what you're saying, I don't understand why we currently do anything on showEvent() But now we're going to call load() twice, which doesn't sound very optimal. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26524 To: apol, #plasma, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26524: configmodule: Make sure the kcm information is loaded when the qml is created
apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we'll initialize with dumb values and refresh it when shown, which isn't all that effective. TEST PLAN Tested against the feedback kcm REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D26524 AFFECTED FILES src/quickaddons/configmodule.cpp To: apol, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
