D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-22 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26701

To: dfaure, broulik, pino, mlaurent
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-22 Thread Laurent Montel 
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  it's ok for me.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26701

To: dfaure, broulik, pino, mlaurent
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-21 Thread David Faure 
dfaure added a reviewer: mlaurent.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26701

To: dfaure, broulik, pino, mlaurent
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-15 Thread David Faure 
dfaure updated this revision to Diff 73671.
dfaure added a comment.


  Fix docu (oops, I'm tired)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26701?vs=73668=73671

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26701

AFFECTED FILES
  src/filewidgets/kfilecustomdialog.cpp
  src/filewidgets/kfilecustomdialog.h

To: dfaure, broulik, pino
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-15 Thread Alexey Min 
alexeymin added inline comments.

INLINE COMMENTS

> kfilecustomdialog.h:40
> +/**
> + * Constructors a custom file dialog
> + */

Constructs?

> kfilecustomdialog.h:45
> +/**
> + * Constructors a custom file dialog
> + * @param startDir see the KFileWidget constructor for documentation

Constructs?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26701

To: dfaure, broulik, pino
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-15 Thread David Faure 
dfaure updated this revision to Diff 73668.
dfaure added a comment.


  off-by-10

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26701?vs=73667=73668

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26701

AFFECTED FILES
  src/filewidgets/kfilecustomdialog.cpp
  src/filewidgets/kfilecustomdialog.h

To: dfaure, broulik, pino
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-15 Thread David Faure 
dfaure created this revision.
dfaure added reviewers: broulik, pino.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This is needed because KFileWidget does special handling of the startDir
  parameter (to detect if it's directory+filename), while setUrl() assumes
  it's a directory.

TEST PLAN
  tested with D26645  in kolourpaint

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26701

AFFECTED FILES
  src/filewidgets/kfilecustomdialog.cpp
  src/filewidgets/kfilecustomdialog.h

To: dfaure, broulik, pino
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns