D26755: [WIP] KMessageWidget: Set widget height on resize event
SGOrava added a comment. it would, but I am not such great guru. I tried few ways to change the behaviour but it was even worse, and since this is used in many programs I do not want to break them. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks Cc: anthonyfieroni, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26755: [WIP] KMessageWidget: Set widget height on resize event
dhaumann added a comment. Well, it definitely would be very nice if you find a patch that fixes this. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks Cc: anthonyfieroni, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26755: [WIP] KMessageWidget: Set widget height on resize event
SGOrava added a comment. This is the test I used to check the validity of my change, it kind of always fails. I only hope someone can fix this widget at least for KF6. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks Cc: anthonyfieroni, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26755: [WIP] KMessageWidget: Set widget height on resize event
SGOrava updated this revision to Diff 73872. SGOrava added a comment. - KMessageWidget: Add resize autotest REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26755?vs=73845=73872 BRANCH more-proper-height (branched from master) REVISION DETAIL https://phabricator.kde.org/D26755 AFFECTED FILES autotests/kmessagewidgetautotest.cpp autotests/kmessagewidgetautotest.h src/kmessagewidget.cpp To: SGOrava, #frameworks Cc: anthonyfieroni, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26755: [WIP] KMessageWidget: Set widget height on resize event
SGOrava added a comment. It looks good. But I wrote a test as you suggested which still fails. The test creates parent widget and puts the kmesagewidget and qlistwidget in it in vertical order (as in my test app) and than it resizes the parent widget and compares the height (the available macros in *autotest.cpp) I will also upload this test. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks Cc: anthonyfieroni, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26755: [WIP] KMessageWidget: Set widget height on resize event
dhaumann resigned from this revision. dhaumann added a comment. This revision now requires review to proceed. In that case I withdraw my review for now. I can only speak for Kate that I could not find a regression with my tests. But if you find other regressions, then this is likely not correct. PS: KMessageWidget is a very unfortunate widget in this sense: We try in the QWidgets world to have nice animations with contents that resizes correctly. To do the animations, we use fixed sizes, however, at the same time the host application's size constraints could change, but if KMessageWidget is still in its animation phase, the wrong old sizes are used for the animation etc... That said, KMessageWidget is likely fundamentally broken, and it needs very careful testing to make sure we don't introduce regressions. That's why I did the tests for Kate/KTextEditor. But of course, also my tests test just a very limited amount of our reald-world scenarios. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks Cc: anthonyfieroni, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26755: [WIP] KMessageWidget: Set widget height on resize event
anthonyfieroni added a comment. That's same issue when file is open then externally modified then updated by kmessagewidget button cause a frame to not resize correct? REPOSITORY R236 KWidgetsAddons BRANCH more-proper-height (branched from master) REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks, dhaumann Cc: anthonyfieroni, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26755: [WIP] KMessageWidget: Set widget height on resize event
SGOrava retitled this revision from "KMessageWidget: Set widget height on resize event" to "[WIP] KMessageWidget: Set widget height on resize event". REPOSITORY R236 KWidgetsAddons BRANCH more-proper-height (branched from master) REVISION DETAIL https://phabricator.kde.org/D26755 To: SGOrava, #frameworks, dhaumann Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
