D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3dfa0c1c2f87: KFilePlacesModel: On new profile in recent 
show only recentlyused:/ based… (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=74123&id=74124

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car 
meven marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D26782_1

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car 
meven updated this revision to Diff 74123.
meven added a comment.


  Fix comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=74072&id=74123

BRANCH
  arcpatch-D26782_1

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kfileplacesmodel.cpp:358
> +
> +// don't add by default "Modifield Today" and "Modifield Yesterday" 
> when recentlyused:/ is present
> +if (root.metaDataItem(QStringLiteral("withRecentlyUsed")) != 
> QLatin1String("true")) {

`s/Modifield/Modified/`

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D26782

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car 
meven updated this revision to Diff 74072.
meven added a comment.


  Clean up

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=74071&id=74072

BRANCH
  arcpatch-D26782

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car 
meven updated this revision to Diff 74071.
meven added a comment.


  Don't add by default 'Modifield Today' and 'Modifield Yesterday' when 
recentlyused:/ is present

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=73995&id=74071

BRANCH
  arcpatch-D26782

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-21 Thread Nathaniel Graham 
ngraham added a comment.


  In D26782#597916 , @meven wrote:
  
  > In D26782#597811 , @ngraham 
wrote>
  >
  > > But should we just hide them, or not even create them in the first place? 
Creating hidden-by-default entries seems a bit off.
  >
  >
  > I chose hidden by value just to keep the feature somewhat more discoverable 
than if it was not present at all.
  >  I would be fine not adding those in the first place too. It may be simpler 
also.
  
  
  I would recommend it. Anything that's hidden by default isn't actually 
discoverable at all, and it sends the wrong message too; it means that we don't 
actually have confidence in the feature (as indeed, we do not for these old 
entries). I think it would be simpler and more appropriate to just not add them 
at all.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-21 Thread Méven Car 
meven updated this revision to Diff 73995.
meven marked an inline comment as done.
meven added a comment.


  Added missing spaces

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=73917&id=73995

BRANCH
  arcpatch-D26782

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-21 Thread Méven Car 
meven added a comment.


  In D26782#597811 , @ngraham wrote>
  
  > But should we just hide them, or not even create them in the first place? 
Creating hidden-by-default entries seems a bit off.
  
  
  I chose hidden by value just to keep the feature somewhat more discoverable 
than if it was not present at all.
  I would be fine not adding those in the first place too. It may be simpler 
also.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Nathaniel Graham 
ngraham added a comment.


  Oh, I thought we already did this. +1 since it was explicitly the plan.
  
  But should we just hide them, or not even create them in the first place? 
Creating hidden-by-default entries seems a bit off.

INLINE COMMENTS

> kfileplacesmodel.cpp:361
>
> QUrl(QStringLiteral("timeline:/today")),  QStringLiteral("go-jump-today"));
> -KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
> +auto modifieldYesterday= 
> KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
>I18NC_NOOP("KFile System 
> Bookmarks", "Modified Yesterday"),

space before the `=`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Méven Car 
meven added a comment.


  Too bad I missed the boat for KF 5.66 and Plasma 5.18.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Méven Car 
meven edited the summary of this revision.
meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Méven Car 
meven updated this revision to Diff 73917.
meven added a comment.


  Clean commit

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=73916&id=73917

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Méven Car 
meven created this revision.
meven added reviewers: ngraham, VDG, Plasma, hein.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  The entries timeline:/today and timeline:/yesterday are way less useful than 
recentlyused:/files and recentlyuse/folders.
  We should expose only one of the two for new installations, to not clutter UI.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/core/desktopexecparser.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns