D26860: Readapt code to new kconfig code

2020-01-23 Thread Laurent Montel 
mlaurent closed this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

2020-01-23 Thread Laurent Montel 
mlaurent added a comment.


  Yep done :)

REPOSITORY
  R237 KConfig

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

2020-01-23 Thread David Faure 
dfaure added a comment.


  Please make sure your commit log talks about \n and endl, not "Readapt code 
to new kconfig code".

REPOSITORY
  R237 KConfig

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

2020-01-23 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

2020-01-22 Thread Laurent Montel 
mlaurent added a comment.


  it replace D26432 
  I don't know why it created a new version

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

2020-01-22 Thread Laurent Montel 
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to "\n" as it's qt namespaced

TEST PLAN
  autotest ok

REPOSITORY
  R237 KConfig

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26860

AFFECTED FILES
  autotests/kconfigtest.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigParameters.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

2020-01-22 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns