D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-22 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:835c64d1b693: [KMessageWidget] Draw it with QPainter 
instead of using stylesheet (authored by davidre).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=76018&id=76174

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham, cfeck
Cc: apol, cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-20 Thread David Redondo 
davidre added a comment.


  So I think this is ready to be merged and I would do so this weekend

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham, cfeck
Cc: apol, cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-20 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 code looks much better!

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham, cfeck
Cc: apol, cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-19 Thread Christoph Feck 
cfeck accepted this revision.
cfeck added a comment.


  Merci :)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham, cfeck
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-19 Thread David Redondo 
davidre updated this revision to Diff 76018.
davidre marked 4 inline comments as done.
davidre added a comment.


  Code style and typos

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=75717&id=76018

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-14 Thread Christoph Feck 
cfeck added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:155
>  };
> -
> +// Add bordersize to the margin so it starts from the inner border and 
> doesn't look to cramped
> +q->layout()->setContentsMargins(q->layout()->contentsMargins() + 
> borderSize);

too

> kmessagewidget.cpp:193
> +textLabel->setPalette(palette);
> +// update the Icon in case its recolorable
> +q->setIcon(icon);

typo: it is

> kmessagewidget.cpp:325
> +constexpr float radius = 4 * 0.6;
> +const QRect innerRect = rect().marginsRemoved(QMargins() + borderSize/2);
> +const QColor color = palette().color(QPalette::Window);

missing spaces around `/`

> kmessagewidget.cpp:397
>  
> -if (isVisible() && (d->timeLine->state() == QTimeLine::NotRunning) && 
> (height() == d->bestContentHeight()) && (d->content->pos().y() == 0)) {
> +if (isVisible() && (d->timeLine->state() == QTimeLine::NotRunning) && 
> (height() == d->bestContentHeight())){
>  emit showAnimationFinished();

missing space before `{`

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-14 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-14 Thread David Redondo 
davidre updated this revision to Diff 75717.
davidre added a comment.


  remove debug remains

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=75716&id=75717

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-14 Thread David Redondo 
davidre updated this revision to Diff 75716.
davidre added a comment.


  Explicitly set TextColor and palettes of the labels and react to parent 
changes . For example necessary for konsole 
  that uses stylesheet which break palette propagation and reparents the widget 
after creation.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=74766&id=75716

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-07 Thread Nathaniel Graham 
ngraham added a comment.


  In D27035#604158 , @davidre wrote:
  
  > Something like this:
  >  F8059669: Screenshot_20200131_163146.PNG 

  
  
  That would be fine, yes.
  
  In the current code I took the approach of always using the system color 
scheme even if the local view overrode it, as Konsole does. Using the view's 
local color scheme isn't incorrect, just different. Arguably it's more correct. 
I say go for it if you think it makes sense.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-07 Thread David Redondo 
davidre added a comment.


  Ping, how should I proceed?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo 
davidre added a comment.


  Something like this:
  F8059669: Screenshot_20200131_163146.PNG 


REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo 
davidre added a comment.


  In D27035#604026 , @ngraham wrote:
  
  > Uh-oh, now it looks like this in Konsole: F8056116: 
Screenshot_20200131_064332.png 
  >
  > Compare to the current appearance: F8056130: Screenshot_20200131_064445.png 

  >
  > I recall wrestling with this issue in D12508 
. Might be worth looking over that.
  
  
  That's because it wants to look transparent and mixes the background color 
with its color. One fix could be to also use the parent's text color (in this 
case white) or stop using `QPalette::Window` for data storage and mix with the 
window color of the widget's palette and use something else (maybe 
QPalette::Base). Opinions?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Uh-oh, now it looks like this in Konsole: F8056116: 
Screenshot_20200131_064332.png 
  
  Compare to the current appearance: F8056130: Screenshot_20200131_064445.png 

  
  I recall wrestling with this issue in D12508 
. Might be worth looking over that.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo 
davidre added a comment.


  In D27035#603619 , @dhaumann wrote:
  
  > Better :) with corners I mean the 1-3 pixels left due to the rounding 
corners. These pixels were once also drawn as background although they are 
outside of the frame. It may be a minor detail, but imho such details are 
important. But indeed, the screenshots look good.
  >
  > Next test: open a file in kate. Now either change the file externally or 
delete it. Kate should show an animated KMessageWidget. Does it also correctly 
work with a small kate? I.e. small width of kate window?
  
  
  It seems to work better than before, on the left the current one, on the 
right this patch:
  F8053466: video.webm 

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo 
davidre updated this revision to Diff 74766.
davidre marked an inline comment as done.
davidre added a comment.


  Use parentWidget()

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=74714&id=74766

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo 
davidre added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:317
> +constexpr float alpha = 0.2;
> +const auto parentWidget = qobject_cast(parent());
> +const QColor parentWindowColor = (parentWidget ? parentWidget->palette() 
> : qApp->palette()).color(QPalette::Window);

I knew there was a function like that but couldn't remember its name. Thanks!

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:39
> +
> +constexpr int borderSize = 2;
> +

I don't think so:

> internal linkage
> [...]
> variables, variable templates (since C++14), functions, or function templates 
> declared static;
> non-volatile non-template (since C++14) non-inline (since C++17) non-exported 
> (since C++20) const-qualified variables (including constexpr) that aren't 
> declared extern and aren't previously declared to have external linkage;

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread Christoph Feck 
cfeck added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:39
> +
> +constexpr int borderSize = 2;
> +

Does it need to be `static` to avoid an external symbol?

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread Dominik Haumann 
dhaumann added a comment.


  Better :) with corners I mean the 1-3 pixels left due to the rounding 
corners. These pixels were once also drawn as background although they are 
outside of the frame. It may be a minor detail, but imho such details are 
important. But indeed, the screenshots look good.
  
  Next test: open a file in kate. Now either change the file externally or 
delete it. Kate should show an animated KMessageWidget. Does it also correctly 
work with a small kate? I.e. small width of kate window?

INLINE COMMENTS

> kmessagewidget.cpp:317
> +constexpr float alpha = 0.2;
> +const auto parentWidget = qobject_cast(parent());
> +const QColor parentWindowColor = (parentWidget ? parentWidget->palette() 
> : qApp->palette()).color(QPalette::Window);

Can't you use parentWidget()?
See: https://doc.qt.io/qt-5/qwidget.html#parentWidget

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre added a comment.


  Kate with this patch and Oxygen style:
  F8030118: Screenshot_20200130_181731.PNG 

  The misplacement I spotted earlier is specific to QtCurve and also happens 
with the current KMessageWidget.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre updated this revision to Diff 74714.
davidre added a comment.


  Draw opaque and mix the colors manually again.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=74697&id=74714

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre added a comment.


  In D27035#603460 , @dhaumann wrote:
  
  > Does that also work in Kate for floating messages like when the search 
wraps? What I want to know is whether the corners behind the green frame are 
transparent in this case, or whether the corners are painted solid. If I 
remember correctly, these kind of bugs were the reason to use Qt StyleSheets. 
And it must work with all styles.
  >
  > Please do NOT yet commit, especially since we'd only have two days of 
testing period: Saturday, 1st of February is the next frameworks tag.
  
  
  Sorry forgot the screenshots, but you're right the text shines through now in 
KTextEditor and it doesn't seem to positioned correctly. For the first one I 
could go back to mixing the color manually instead of just drawing it with an 
alpha of 0.2. I will look into the second issue

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre added a comment.


  In D27035#603460 , @dhaumann wrote:
  
  > Does that also work in Kate for floating messages like when the search 
wraps? What I want to know is whether the corners behind the green frame are 
transparent in this case, or whether the corners are painted solid. If I 
remember correctly, these kind of bugs were the reason to use Qt StyleSheets. 
And it must work with all styles.
  >
  > Please do NOT yet commit, especially since we'd only have two days of 
testing period: Saturday, 1st of February is the next frameworks tag.
  
  
  Should or shouldn't it be transparent? Also I don't understand which part 
should be transparent and which shouldn't? The border was never transparent and 
the background also not. Screenshots:
  
  In D27035#603462 , @dhaumann wrote:
  
  > Can you provide screenshots of more styles? :-)
  
  
  Of course: 
  Adwaita F8029130: Screenshot_20200130_174346.PNG 

  Adwaita Dark F8029135: Screenshot_20200130_174408.PNG 

  Fusion F8029141: Screenshot_20200130_174436.PNG 

  MS Windows 9x{F8029146 }
  Oxygen F8029149: Screenshot_20200130_174522.PNG 

  QtCurve{F8029154 }

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread Dominik Haumann 
dhaumann added a comment.


  Can you provide screenshots of more styles? :-)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread Dominik Haumann 
dhaumann added a comment.


  Does that also work in Kate for floating messages like when the search wraps? 
What I want to know is whether the corners behind the green frame are 
transparent in this case, or whether the corners are painted solid. If I 
remember correctly, these kind of bugs were the reason to use Qt StyleSheets. 
And it must work with all styles.
  
  Please do NOT yet commit, especially since we'd only have two days of testing 
period: Saturday, 1st of February is the next frameworks tag.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre added a dependent revision: D27038: [KMessageWidget] Allow the style to 
change our palette.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre added a comment.


  In D27035#603375 , @davidre wrote:
  
  > The border radius is slightly different because I copied what Kirigami does 
for the inner rect but I can also go back to radius 4
  
  
  Nevermind that was because of above mistake

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre edited the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre updated this revision to Diff 74697.
davidre added a comment.


  Tiny mistakes

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=74693&id=74697

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre added a comment.


  The border radius is slightly different because I copied what Kirigami does 
for the inner rect but I can also go back to radius 4

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice. Much simpler and more comprehensible now.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre edited the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo 
davidre created this revision.
davidre added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  While being a prepatory step to KMessageWidget respecting the current color
  scheme via KStyle this also simplifies this widget by a huge amount. This
  includes removing the nested content Frame and the indirection via a QPixmap
  for the animations.

TEST PLAN
  kmessagewidgettest works as before

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns