D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-25 Thread Cyril Rossi 
crossi added a dependent revision: D27188: KCM Notifications : Manage 
app-specific notifications with KCconfigXT's magic.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-24 Thread Cyril Rossi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:c8bf5e96cf2f: KConfigSkeletonItem : allow to set a 
KconfigGroup to read and write items in… (authored by crossi).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=76281&id=76282

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-24 Thread Kevin Ottens 
ervin accepted this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-24 Thread Cyril Rossi 
crossi marked an inline comment as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-24 Thread Cyril Rossi 
crossi updated this revision to Diff 76281.
crossi added a comment.


  fix comment

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=75829&id=76281

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-24 Thread Kevin Ottens 
ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  LGTM, please don't forget to address dfaure's comment before pushing though.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-24 Thread Kevin Ottens 
ervin added a comment.


  In D27059#612205 , @dfaure wrote:
  
  > Well, I'm not the KConfig maintainer, mdawson is :-)
  
  
  Well, my understanding is that mdawson is MIA, so I rely on the old "dfaure 
as default maintainer" model. ;-)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-17 Thread David Faure 
dfaure accepted this revision.
dfaure added inline comments.

INLINE COMMENTS

> kcoreconfigskeleton.h:459
> +// given we can't, I've shadowed the method. This isn't pretty, but given
> +// the docs say it should generally only be used from auto generated 
> code,
>  void setWriteFlags(KConfigBase::WriteConfigFlags flags);

the end of the sentence is missing.  ("should be fine")

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-17 Thread Cyril Rossi 
crossi added a reviewer: mdawson.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-17 Thread Cyril Rossi 
crossi marked an inline comment as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-17 Thread Cyril Rossi 
crossi marked 9 inline comments as done.
crossi added inline comments.

INLINE COMMENTS

> ervin wrote in kcoreconfigskeleton.h:448
> That's my understanding to have them virtuals in KF6 indeed, that was 
> introduced by David Edmundson a little while ago. This is necessary because 
> of the way KConfigSkeletonItem is done and because 
> KConfigCompilerSignallingItem is basically a decorator.

Added David's comment from D25791  to make 
things clearer on what to do.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-17 Thread Cyril Rossi 
crossi updated this revision to Diff 75829.
crossi added a comment.


  Comments

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=74799&id=75829

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-16 Thread Kevin Ottens 
ervin added inline comments.

INLINE COMMENTS

> dfaure wrote in kcoreconfigskeleton.h:448
> So this KF6 TODO is to make those methods virtual? It's a bit unclear to me...
> 
> I'm asking because: if the solution is something else then maybe it can be 
> done already for those new methods.

That's my understanding to have them virtuals in KF6 indeed, that was 
introduced by David Edmundson a little while ago. This is necessary because of 
the way KConfigSkeletonItem is done and because KConfigCompilerSignallingItem 
is basically a decorator.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-16 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Well, I'm not the KConfig maintainer, mdawson is :-)

INLINE COMMENTS

> kcoreconfigskeleton.h:89
> + */
> +void setGroup(const KConfigGroup &cg);
> +

Missing @since 5.68

> kcoreconfigskeleton.h:96
> + * @sa setGroup(KConfigGroup cg)
> + */
> +KConfigGroup configGroup(KConfig *config) const;

Missing @since 5.68

> kcoreconfigskeleton.h:448
>  void swapDefault() override;
>  // shadow the method in KConfigSkeletonItem, which should be fine for 
> autogenerated code
>  // KF6 TODO - fix this

So this KF6 TODO is to make those methods virtual? It's a bit unclear to me...

I'm asking because: if the solution is something else then maybe it can be done 
already for those new methods.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-12 Thread Kevin Ottens 
ervin added a comment.


  LGTM, giving a couple more days for @dfaure to react to it though.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-06 Thread Cyril Rossi 
crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-02-03 Thread Kevin Ottens 
ervin added reviewers: dfaure, Frameworks.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-01-31 Thread Cyril Rossi 
crossi updated this revision to Diff 74799.
crossi added a comment.


  code style

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=74756&id=74799

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-01-31 Thread Kevin Ottens 
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Sorry, couple of further style fixes I missed on the previous run

INLINE COMMENTS

> kcoreconfigskeleton.cpp:1616
> +
> +void KConfigCompilerSignallingItem::setGroup(const KConfigGroup& cg)
> +{

Space before & not after

> kcoreconfigskeleton.cpp:1621
> +
> +KConfigGroup KConfigCompilerSignallingItem::configGroup(KConfig* config) 
> const
> +{

Space before * not after

> kcoreconfigskeleton.h:453
> +void setGroup(const KConfigGroup &cg);
> +KConfigGroup configGroup(KConfig* config) const;
> +// END TODO

Space before * not after

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-01-31 Thread Cyril Rossi 
crossi updated this revision to Diff 74756.
crossi added a comment.


  code style

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=74754&id=74756

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-01-31 Thread Kevin Ottens 
ervin added inline comments.

INLINE COMMENTS

> kcoreconfigskeleton.h:86
> +/**
> + * Set config file group bu giving the KConfigGroup.
> + * Allow the item to be in nested groups.

s/bu/but/

> kcoreconfigskeleton.h:97
> + */
> +KConfigGroup configGroup(KConfig* config) const;
> +

Space before * not after.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-01-31 Thread Cyril Rossi 
crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-01-31 Thread Cyril Rossi 
crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

2020-01-31 Thread Cyril Rossi 
crossi created this revision.
crossi added a reviewer: ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Currently KConfgiSkeleton cannot manage item entry in subgroup.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns