D27223: add kirigami-gallery icon

2020-07-29 Thread Noah Davis 
ndavis abandoned this revision.
ndavis added a comment.


  I've committed the icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: ndavis, mart, #vdg, ngraham, mbruchert
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

2020-07-29 Thread Noah Davis 
ndavis commandeered this revision.
ndavis edited reviewers, added: mbruchert; removed: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: ndavis, mart, #vdg, ngraham, mbruchert
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

2020-06-08 Thread Noah Davis 
ndavis added a comment.


  I think I'd prefer to keep this similar to the original Kirigami icon. Do you 
mind if I commandeer this? I've already made the changes.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

2020-06-08 Thread Noah Davis 
ndavis added a comment.


  I noticed that the lighting in this version of the Kirigami is flipped. Is 
that intentional? I don't think it makes sense for the top of the K popout to 
be darker than the bottom. Since the light in Breeze icons comes from the top 
left, the top should be light, like in the original Kirigami icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

2020-06-08 Thread Mathis Brüchert 
mbruchert added a comment.


  I believe everything should be fixed now

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

2020-06-08 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 83252.
mbruchert added a comment.


  - fix color

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27223?vs=83251=83252

BRANCH
  kirigami_galery (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27223

AFFECTED FILES
  icons-dark/apps/48/kirigami-gallery.svg
  icons/apps/48/kirigami-gallery.svg

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

2020-06-08 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 83251.
mbruchert added a comment.


  - align pixel grid
  - fix typo
  - fix overlapping bug

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27223?vs=75859=83251

BRANCH
  kirigami_galery (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27223

AFFECTED FILES
  icons-dark/apps/48/kirigami-gallery.svg
  icons/apps/48/kirigami-gallery.svg

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

2020-06-08 Thread Marco Martin 
mart added a comment.


  can we fix this and go ahead?
  @mbruchert can you still work on it? want to put it on invent?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

2020-03-12 Thread Noah Davis 
ndavis added a comment.


  In D27223#626722 , @ngraham wrote:
  
  > Sorry this got lost.
  >
  > Still looks kinda jaggy to me though, especially at 48px.: F8172949: 
Screenshot_20200312_204742.png 
  >
  > Do you think you could clean up the outline a bit?
  
  
  Just to give some direction, I've found that the easiest way to fix these 
kinds of issues is to cut away the outside edge of the part that is sticking 
out. In theory, making shapes overlap perfectly should prevent the covered bits 
from showing. In practice, SVG renderers sometimes draw an outline of the part 
underneath around the part that is above.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27223: add kirigami-gallery icon

2020-03-12 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Sorry this got lost.
  
  Still looks kinda jaggy to me though, especially at 48px.: F8172949: 
Screenshot_20200312_204742.png 
  
  Do you think you could clean up the outline a bit?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27223: add kirigami-gallery icon

2020-02-17 Thread Mathis Brüchert 
mbruchert added a comment.


  thank you so much!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis
Cc: ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27223: add kirigami-gallery icon

2020-02-17 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 75859.
mbruchert added a comment.


  - fix issues

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27223?vs=75772=75859

BRANCH
  arcpatch-D27223

REVISION DETAIL
  https://phabricator.kde.org/D27223

AFFECTED FILES
  icons-dark/apps/48/kirigami-gallery.svg
  icons/apps/48/kirigami-gallery.svg

To: mbruchert, mart, #vdg, ndavis
Cc: ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27223: add kirigami-gallery icon

2020-02-16 Thread Carl Schwan 
ognarb added a comment.


  In D27223#612284 , @mbruchert 
wrote:
  
  > I have no Idea why the diff deletes the ktrip icon.
  >  unfortunately I cant fix that because I have no Idea how to do that with 
git.
  
  
  You can try to execute this git command to solve this problem :)
  
git checkout origin/master icons/apps/48/ktrip.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis
Cc: ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27223: add kirigami-gallery icon

2020-02-16 Thread Mathis Brüchert 
mbruchert added a comment.


  I have no Idea why the diff deletes the ktrip icon.
  unfortunately I cant fix that because I have no Idea how to do that with git.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27223: add kirigami-gallery icon

2020-02-16 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 75772.
mbruchert added a comment.


  - fix issues

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27223?vs=75771=75772

BRANCH
  arcpatch-D27223

REVISION DETAIL
  https://phabricator.kde.org/D27223

AFFECTED FILES
  icons-dark/apps/48/kirigami-gallery.svg
  icons/apps/48/kirigami-gallery.svg
  icons/apps/48/ktrip.svg

To: mbruchert, mart, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27223: add kirigami-gallery icon

2020-02-16 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 75771.
mbruchert added a comment.


  - fix issues

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27223?vs=75228=75771

BRANCH
  arcpatch-D27223

REVISION DETAIL
  https://phabricator.kde.org/D27223

AFFECTED FILES
  icons-dark/apps/48/itinerary.svg
  icons-dark/apps/48/kirigami-gallery.svg
  icons-dark/apps/48/ktrip.svg
  icons/apps/48/itinerary.svg
  icons/apps/48/kirigami-gallery.svg
  icons/apps/48/ktrip.svg

To: mbruchert, mart, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27223: add kirigami-gallery icon

2020-02-15 Thread Noah Davis 
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  You've got a duplicate copy of the icon in there. The bottom shadow should 
also be changed to be dark gray, like a darker version of the normal background 
color rather than a dark blue.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27223: add kirigami-gallery icon

2020-02-11 Thread Mathis Brüchert 
mbruchert added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

2020-02-08 Thread Mathis Brüchert 
mbruchert added a reviewer: mart.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

2020-02-08 Thread Mathis Brüchert 
mbruchert removed a reviewer: marcorichetta.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, marcorichetta
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

2020-02-08 Thread Mathis Brüchert 
mbruchert added a reviewer: marcorichetta.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, marcorichetta
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

2020-02-08 Thread Mathis Brüchert 
mbruchert retitled this revision from "add kirigami-galery icon" to "add 
kirigami-gallery icon".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns