D27459: Port QLinkedList which is deprecated in qt5.15

2020-02-18 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:c5863523f3aa: Port QLinkedList which is deprecated in 
qt5.15 (authored by mlaurent).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27459?vs=75830=75936

REVISION DETAIL
  https://phabricator.kde.org/D27459

AFFECTED FILES
  src/ktoolbarhandler.cpp

To: mlaurent, dfaure, apol
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27459: Port QLinkedList which is deprecated in qt5.15

2020-02-18 Thread David Faure 
dfaure added a comment.


  This code only seems to do append() and contains(), a QVector (contiguous 
area of memory) is better than a std::list (individual nodes spread all over 
the memory, more cache lines to load)

REPOSITORY
  R263 KXmlGui

BRANCH
  port_QLinkedList (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27459

To: mlaurent, dfaure, apol
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27459: Port QLinkedList which is deprecated in qt5.15

2020-02-18 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D27459#613205 , @aacid wrote:
  
  > Are we sure we can lose the features of QLinkedList here?
  >
  > maybe makes more sense to use std::list that has the same features as 
QLinkedList?
  
  
  I thought so too, but we just iterate and append to it QVector should be fine 
there.
  Could be missing something...

REPOSITORY
  R263 KXmlGui

BRANCH
  port_QLinkedList (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27459

To: mlaurent, dfaure, apol
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27459: Port QLinkedList which is deprecated in qt5.15

2020-02-17 Thread Albert Astals Cid 
aacid added a comment.


  Are we sure we can lose the features of QLinkedList here?
  
  maybe makes more sense to use std::list that has the same features as 
QLinkedList?

REPOSITORY
  R263 KXmlGui

BRANCH
  port_QLinkedList (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27459

To: mlaurent, dfaure, apol
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27459: Port QLinkedList which is deprecated in qt5.15

2020-02-17 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  port_QLinkedList (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27459

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

2020-02-17 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D27459

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

2020-02-17 Thread Laurent Montel 
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port QLinkedList (deprecated in qt5.15)

REPOSITORY
  R263 KXmlGui

BRANCH
  port_QLinkedList (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27459

AFFECTED FILES
  src/ktoolbarhandler.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns