D27475: Make kwapper/kshell spawn klauncher5 if needed

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R303:f3264622f96d: Make kwrapper/kshell spawn klauncher5 if 
needed (authored by davidedmundson).

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27475?vs=75924=76757

REVISION DETAIL
  https://phabricator.kde.org/D27475

AFFECTED FILES
  CMakeLists.txt
  src/kdeinit/CMakeLists.txt
  src/kshell/CMakeLists.txt
  src/kwrapper/CMakeLists.txt
  src/wrapper.cpp

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27475: Make kwapper/kshell spawn klauncher5 if needed

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27475

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27475: Make kwapper/kshell spawn klauncher5 if needed

[David Edmundson]

davidedmundson updated this revision to Diff 75924.
davidedmundson added a comment.


  update

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27475?vs=75914=75924

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27475

AFFECTED FILES
  CMakeLists.txt
  src/kdeinit/CMakeLists.txt
  src/kshell/CMakeLists.txt
  src/kwrapper/CMakeLists.txt
  src/wrapper.cpp

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27475: Make kwapper/kshell spawn klauncher5 if needed

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:57
>  find_package(KF5Config ${KF5_DEP_VERSION} REQUIRED)
> +find_package(KF5DBusAddons ${KF5_DEP_VERSION} REQUIRED)
>  find_package(KF5DocTools ${KF5_DEP_VERSION})

I suppose this should be if (NOT WIN32)?

I'm not entirely sure why it's just added to some.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D27475

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27475: Make kwapper/kshell spawn klauncher5 if needed

[David Edmundson]

davidedmundson added a comment.


  Requires D27476  to not crash

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D27475

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27475: Make kwapper/kshell spawn klauncher5 if needed

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In an attempt to phase kinit out plasma will at some point stop spawning 
klauncher5
  
  This means we need the cli-tools to spawn it themselves if activated for
  full compatibility

TEST PLAN
  didn't spawn kdeinit5
  ran kwrapper5 ls

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27475

AFFECTED FILES
  CMakeLists.txt
  src/kdeinit/CMakeLists.txt
  src/kshell/CMakeLists.txt
  src/kwrapper/CMakeLists.txt
  src/wrapper.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns