D27508: Remove unnecessary monochrome app icons

[Noah Davis]

ndavis added a comment.


  T10413 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27508: Remove unnecessary monochrome app icons

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  What's the phab task you filed about this again? I can't find it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27508: Remove unnecessary monochrome app icons

[Noah Davis]

ndavis added a comment.


  In D27508#614856 , @ngraham wrote:
  
  > Removing the monochrome system-help icon is what's needed to fix 417879, 
though. If we can't do that, then we can't fix the bug.
  
  
  We're back to needing to solve the fundamental technical issue with Breeze 
Icons. Removing or adding icons isn't going to fix it. We've got to create a 
way to force apps to use monochrome icons when we want to use them and I don't 
know how to do that. Alternatively, we could redesign Breeze to work better 
with the XDG spec, but I don't have the time, creativity or drive to create 
tons of good replacement icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27508: Remove unnecessary monochrome app icons

[Nathaniel Graham]

ngraham added a comment.


  Removing the monochrome system-help icon is what's needed to fix 417879, 
though. If we can't do that, then we can't fix the bug.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27508: Remove unnecessary monochrome app icons

[Noah Davis]

ndavis added a comment.


  I don't know what hotspot is used for, but the other ones are probably used 
by 3rd party apps. The virt-manager and system-help icons are definitely used 
by 3rd party apps in places where monochrome icons should be.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27508: Remove unnecessary monochrome app icons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is a continuation of the ongoing issue we have in reliably making icons 
colorful
  or monochrome in a predictible manner. Currently there are certain app icons 
that have
  monochrome versions, primarily to make them look better in the system tray. 
However other
  monochrome app icons exist for no clear reason. This patch removes those, 
while not
  touching the monochrome app icons.

TEST PLAN
  khelpcenter icon is now consistently colorful in the task manager, window 
decoration,
  and task switcher
  
  One conseauence is that now "Help" menu items and buttons that use the 
`system-help` icon
  are now colorful, which is arguably correct because those actions will open 
the KHelpCenter
  app, and we generally use colorful app icons in places where actions will 
open an app.

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-unnecessary-monochrome-app-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27508

AFFECTED FILES
  icons-dark/actions/16/help-contents.svg
  icons-dark/actions/22/help-contents.svg
  icons-dark/apps/16/help-browser.svg
  icons-dark/apps/16/hotspot.svg
  icons-dark/apps/16/preferences-system-bluetooth.svg
  icons-dark/apps/16/system-help.svg
  icons-dark/apps/16/virt-manager.svg
  icons-dark/apps/22/help-browser.svg
  icons-dark/apps/22/hotspot.svg
  icons-dark/apps/22/preferences-other.svg
  icons-dark/apps/22/preferences-plugin.svg
  icons-dark/apps/22/system-help.svg
  icons-dark/apps/22/virt-manager.svg
  icons-dark/apps/32/hotspot.svg
  icons/actions/16/help-contents.svg
  icons/actions/22/help-contents.svg
  icons/apps/16/help-browser.svg
  icons/apps/16/hotspot.svg
  icons/apps/16/preferences-system-bluetooth.svg
  icons/apps/16/system-help.svg
  icons/apps/16/virt-manager.svg
  icons/apps/22/help-browser.svg
  icons/apps/22/hotspot.svg
  icons/apps/22/preferences-other.svg
  icons/apps/22/preferences-plugin.svg
  icons/apps/22/system-help.svg
  icons/apps/22/virt-manager.svg
  icons/apps/32/hotspot.svg

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27508: Remove unnecessary monochrome app icons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27508

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns